Make HasCapability private#3303
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3303 +/- ##
==========================================
- Coverage 78.59% 78.54% -0.06%
==========================================
Files 181 181
Lines 12546 12581 +35
==========================================
+ Hits 9861 9882 +21
- Misses 2252 2265 +13
- Partials 433 434 +1
|
crodriguezvega
left a comment
There was a problem hiding this comment.
Thank you, @expertdicer!
modules/apps/27-interchain-accounts/controller/keeper/export_test.go
Outdated
Show resolved
Hide resolved
You're welcome! |
crodriguezvega
left a comment
There was a problem hiding this comment.
Thank you, @expertdicer. I think if we remove those testing functions and rebase with main, the PR should be ready to be merged. :)
crodriguezvega
left a comment
There was a problem hiding this comment.
Thank you, @expertdicer. I think if we remove those testing functions and rebase with main, the PR should be ready to be merged. :)
95da490 to
6f429f5
Compare
crodriguezvega
left a comment
There was a problem hiding this comment.
We're almost there, @expertdicer! Just need to make the linter happy now. :)
modules/apps/27-interchain-accounts/controller/keeper/genesis.go
Outdated
Show resolved
Hide resolved
damiannolan
left a comment
There was a problem hiding this comment.
Thanks @expertdicer ❤️
colin-axner
left a comment
There was a problem hiding this comment.
Thank you @expertdicer! Appreciate the followups and your patience 🙏
Description
closes: #3289
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.