Skip to content

Make HasCapability private#3303

Merged
crodriguezvega merged 10 commits intocosmos:mainfrom
notional-labs:nguyen/private-capability
Apr 14, 2023
Merged

Make HasCapability private#3303
crodriguezvega merged 10 commits intocosmos:mainfrom
notional-labs:nguyen/private-capability

Conversation

@expertdicer
Copy link
Copy Markdown
Contributor

@expertdicer expertdicer commented Mar 16, 2023

Description

closes: #3289

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@expertdicer expertdicer changed the title Nguyen/private capability Make HasCapability private Mar 16, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #3303 (fd52dfd) into main (b562f24) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3303      +/-   ##
==========================================
- Coverage   78.59%   78.54%   -0.06%     
==========================================
  Files         181      181              
  Lines       12546    12581      +35     
==========================================
+ Hits         9861     9882      +21     
- Misses       2252     2265      +13     
- Partials      433      434       +1     
Impacted Files Coverage Δ
...7-interchain-accounts/controller/keeper/account.go 80.85% <100.00%> (ø)
...7-interchain-accounts/controller/keeper/genesis.go 92.00% <100.00%> (ø)
...27-interchain-accounts/controller/keeper/keeper.go 89.65% <100.00%> (ø)
...apps/27-interchain-accounts/host/keeper/genesis.go 89.47% <100.00%> (ø)
.../apps/27-interchain-accounts/host/keeper/keeper.go 85.57% <100.00%> (ø)
modules/apps/transfer/keeper/genesis.go 89.47% <100.00%> (ø)
modules/apps/transfer/keeper/keeper.go 91.17% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @expertdicer!

@expertdicer
Copy link
Copy Markdown
Contributor Author

Thank you, @expertdicer!

You're welcome!

Copy link
Copy Markdown
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @expertdicer. I think if we remove those testing functions and rebase with main, the PR should be ready to be merged. :)

Copy link
Copy Markdown
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @expertdicer. I think if we remove those testing functions and rebase with main, the PR should be ready to be merged. :)

@expertdicer expertdicer force-pushed the nguyen/private-capability branch from 95da490 to 6f429f5 Compare April 6, 2023 04:14
Copy link
Copy Markdown
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there, @expertdicer! Just need to make the linter happy now. :)

Copy link
Copy Markdown
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @expertdicer ❤️

Copy link
Copy Markdown
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @expertdicer! Appreciate the followups and your patience 🙏

@crodriguezvega crodriguezvega merged commit c043dbd into cosmos:main Apr 14, 2023
@expertdicer expertdicer deleted the nguyen/private-capability branch April 14, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make HasCapability private

6 participants