Revert "Save gas on IsFeeEnabled (backport #2786) (#2814)"#3660
Merged
crodriguezvega merged 4 commits intorelease/v4.1.xfrom May 25, 2023
Merged
Revert "Save gas on IsFeeEnabled (backport #2786) (#2814)"#3660crodriguezvega merged 4 commits intorelease/v4.1.xfrom
crodriguezvega merged 4 commits intorelease/v4.1.xfrom
Conversation
AdityaSripal
approved these changes
May 25, 2023
Contributor
AdityaSripal
left a comment
There was a problem hiding this comment.
Ack, though I'd like some verification from impacted user that this was the cause of any app hash mismatch
Contributor
I will contact the user that reported this and ask if they can try it. |
crodriguezvega
approved these changes
May 25, 2023
Contributor
|
Thank you, @colin-axner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit dd2c03e.
The saving gas commit was backported to the v4.1.x line, but changing gas usage is state machine breaking as
GasUsedis included in a transaction response hash which is in consensus. This commit reverts that change. v4.1.2 should then be retracted and replaced with v4.1.3Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.