chore: add deprecated option to MsgSubmitMisbehaviour#3893
Merged
crodriguezvega merged 3 commits intomainfrom Jun 20, 2023
Merged
chore: add deprecated option to MsgSubmitMisbehaviour#3893crodriguezvega merged 3 commits intomainfrom
MsgSubmitMisbehaviour#3893crodriguezvega merged 3 commits intomainfrom
Conversation
crodriguezvega
requested review from
AdityaSripal,
colin-axner and
damiannolan
as code owners
DimitrisJim
approved these changes
Jun 19, 2023
Contributor
DimitrisJim
left a comment
DimitrisJim
left a comment
There was a problem hiding this comment.
similar micro-nit as the other, other than that, lgtm
colin-axner
added
the
type: code hygiene
colin-axner
approved these changes
Jun 19, 2023
damiannolan
approved these changes
Jun 20, 2023
Contributor
damiannolan
left a comment
damiannolan
left a comment
There was a problem hiding this comment.
Nice! Much better than 3 field options 😅
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3893 +/- ##
=======================================
Coverage 78.87% 78.88%
=======================================
Files 187 187
Lines 12939 12944 +5
=======================================
+ Hits 10206 10211 +5
Misses 2305 2305
Partials 428 428
|
crodriguezvega
deleted the
carlos/add-deprecated-option-msgsubmitmisbehaviour
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The messages was deprecated with 02-client refactor. This PR sets the deprecated option for the whole message, instead of the individual fields of the message.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.