Skip to content

change import alias from tm to cmt to reduce diffs in sdk upgrade review#4178

Merged
colin-axner merged 2 commits intomainfrom
colin/diff-reduction-1
Jul 27, 2023
Merged

change import alias from tm to cmt to reduce diffs in sdk upgrade review#4178
colin-axner merged 2 commits intomainfrom
colin/diff-reduction-1

Conversation

@colin-axner
Copy link
Copy Markdown
Contributor

Description

Diff reduction, changes import alias from tm to cmt to reduce diffs in the SDK upgrade, see changes here, here, and here

closes: #XXXX

Commit Message / Changelog Entry

N/A

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this touches the files that were included in the sdk upgrade. Pointing this out since it appears tmtypes (I'd assume others too) is also used in other places (tendermint light client is specifically one spot)

Could def open an issue for those.

Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

durr wrong button

@colin-axner
Copy link
Copy Markdown
Contributor Author

I'm guessing this touches the files that were included in the sdk upgrade. Pointing this out since it appears tmtypes (I'd assume others too) is also used in other places (tendermint light client is specifically one spot)

Yes that's correct. Only focusing on already made changes in the next upgrade. I'd be open to switching tmtypes to cmttypes across the board

@colin-axner colin-axner enabled auto-merge (squash) July 27, 2023 10:17
@colin-axner colin-axner merged commit e817884 into main Jul 27, 2023
@colin-axner colin-axner deleted the colin/diff-reduction-1 branch July 27, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants