change import alias from tm to cmt to reduce diffs in sdk upgrade review#4178
Merged
colin-axner merged 2 commits intomainfrom Jul 27, 2023
Merged
change import alias from tm to cmt to reduce diffs in sdk upgrade review#4178colin-axner merged 2 commits intomainfrom
colin-axner merged 2 commits intomainfrom
Conversation
DimitrisJim
reviewed
Jul 26, 2023
Contributor
There was a problem hiding this comment.
I'm guessing this touches the files that were included in the sdk upgrade. Pointing this out since it appears tmtypes (I'd assume others too) is also used in other places (tendermint light client is specifically one spot)
Could def open an issue for those.
Contributor
Author
Yes that's correct. Only focusing on already made changes in the next upgrade. I'd be open to switching |
3 tasks
crodriguezvega
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Diff reduction, changes import alias from
tmtocmtto reduce diffs in the SDK upgrade, see changes here, here, and herecloses: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.