Conversation
4 tasks
crodriguezvega
requested review from
AdityaSripal,
DimitrisJim,
charleenfei,
chatton,
damiannolan and
srdtrk
as code owners
…tacmd-cli-to-use-proper-encoding-format
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4537 +/- ##
==========================================
- Coverage 79.26% 79.20% -0.06%
==========================================
Files 188 188
Lines 13054 13063 +9
==========================================
Hits 10347 10347
- Misses 2273 2282 +9
Partials 434 434
|
Member
|
Should we backport this to |
…tacmd-cli-to-use-proper-encoding-format
srdtrk
approved these changes
Sep 1, 2023
Member
srdtrk
left a comment
srdtrk
left a comment
There was a problem hiding this comment.
See my comment about possibly backporting this
srdtrk
reviewed
Sep 1, 2023
Contributor
Author
Yes, sounds good. We can do that. |
…tacmd-cli-to-use-proper-encoding-format
damiannolan
approved these changes
Sep 4, 2023
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
…tacmd-cli-to-use-proper-encoding-format
srdtrk
deleted the
carlos/3974-add-argument-to-generatepacketdatacmd-cli-to-use-proper-encoding-format
branch
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
…ing format (#4537) * add encoding parameter to cli * updated docs * testing encoding parameter of cli * linter fixes * review feedback * Update client.md * typos * Update modules/apps/27-interchain-accounts/host/client/cli/tx.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * address review feedback --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 1e3eee6) # Conflicts: # modules/apps/27-interchain-accounts/host/client/cli/tx.go # modules/apps/27-interchain-accounts/host/client/cli/tx_test.go
crodriguezvega
added a commit
that referenced
this pull request
Sep 7, 2023
…ing format (backport #4537) (#4569) * imp: add argument to `generate-packet-data` cli to use selected encoding format (#4537) * add encoding parameter to cli * updated docs * testing encoding parameter of cli * linter fixes * review feedback * Update client.md * typos * Update modules/apps/27-interchain-accounts/host/client/cli/tx.go Co-authored-by: Damian Nolan <damiannolan@gmail.com> * address review feedback --------- Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com> (cherry picked from commit 1e3eee6) # Conflicts: # modules/apps/27-interchain-accounts/host/client/cli/tx.go # modules/apps/27-interchain-accounts/host/client/cli/tx_test.go * fix: fixed backport conflicts * add changelog --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: srdtrk <srdtrk@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #3974
Commit Message / Changelog Entry
imp: add argument to `generate-packet-data` cli to use selected encoding formatsee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.