chore(api)!: make port keeper pointer#4703
Merged
crodriguezvega merged 11 commits intomainfrom Sep 19, 2023
Merged
Conversation
crodriguezvega
requested review from
AdityaSripal,
DimitrisJim,
charleenfei,
chatton,
colin-axner,
damiannolan and
srdtrk
as code owners
damiannolan
reviewed
Sep 18, 2023
| connectionKeeper := connectionkeeper.NewKeeper(cdc, key, paramSpace, clientKeeper) | ||
| portKeeper := portkeeper.NewKeeper(scopedKeeper) | ||
| channelKeeper := channelkeeper.NewKeeper(cdc, key, clientKeeper, connectionKeeper, portKeeper, scopedKeeper) | ||
| channelKeeper := channelkeeper.NewKeeper(cdc, key, clientKeeper, connectionKeeper, &portKeeper, scopedKeeper) |
Contributor
There was a problem hiding this comment.
I wonder if we should make portkeeper.NewKeeper return a pointer, what do you think?
Contributor
There was a problem hiding this comment.
Happy to do in a followup if it isn't straightforward of a change
colin-axner
reviewed
Sep 18, 2023
Contributor
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Looks like the callbacks simapp needs to be updated as well
| connectionKeeper := connectionkeeper.NewKeeper(cdc, key, paramSpace, clientKeeper) | ||
| portKeeper := portkeeper.NewKeeper(scopedKeeper) | ||
| channelKeeper := channelkeeper.NewKeeper(cdc, key, clientKeeper, connectionKeeper, portKeeper, scopedKeeper) | ||
| channelKeeper := channelkeeper.NewKeeper(cdc, key, clientKeeper, connectionKeeper, &portKeeper, scopedKeeper) |
Contributor
There was a problem hiding this comment.
Happy to do in a followup if it isn't straightforward of a change
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4703 +/- ##
=======================================
Coverage 79.73% 79.73%
=======================================
Files 187 187
Lines 13195 13195
=======================================
Hits 10521 10521
Misses 2246 2246
Partials 428 428
|
colin-axner
approved these changes
Sep 19, 2023
damiannolan
approved these changes
Sep 19, 2023
DimitrisJim
approved these changes
Sep 19, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
chore(api)!: make port keeper pointersee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.