Skip to content

chore: add HasValidateBasic compiler assertions to msgs#4724

Merged
DimitrisJim merged 4 commits intocosmos:mainfrom
trinitys7:has-validate-basic
Sep 20, 2023
Merged

chore: add HasValidateBasic compiler assertions to msgs#4724
DimitrisJim merged 4 commits intocosmos:mainfrom
trinitys7:has-validate-basic

Conversation

@trinitys7
Copy link
Copy Markdown
Contributor

Description

Add the HasValidateBasic interface as a compiler assertion to each of the ibc-go tx msgs.

closes: #4665

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Copy Markdown
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trinitys7!

@DimitrisJim DimitrisJim merged commit e647a2c into cosmos:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HasValidateBasic compiler assertions to msgs

3 participants