Use global wasm VM instead of keeping an additional reference in keeper.#5146
Merged
DimitrisJim merged 1 commit intomainfrom Nov 21, 2023
Merged
Use global wasm VM instead of keeping an additional reference in keeper.#5146DimitrisJim merged 1 commit intomainfrom
DimitrisJim merged 1 commit intomainfrom
Conversation
DimitrisJim
requested review from
AdityaSripal,
charleenfei,
chatton,
colin-axner,
damiannolan and
srdtrk
as code owners
DimitrisJim
force-pushed
the
jim/use-global-vm
branch
from
f032d3b to
21131f8
Compare
damiannolan
approved these changes
Nov 21, 2023
Contributor
damiannolan
left a comment
damiannolan
left a comment
There was a problem hiding this comment.
Love the cleanup! Good stuff 🙌
crodriguezvega
pushed a commit
that referenced
this pull request
Nov 29, 2023
…er. (backport #5146) (#5248) * Use global wasm VM instead of keeping an additional reference in keeper. (#5146) (cherry picked from commit 595e1a9) # Conflicts: # modules/light-clients/08-wasm/keeper/genesis.go # modules/light-clients/08-wasm/keeper/keeper.go # modules/light-clients/08-wasm/keeper/snapshotter.go * Fix conflicts. * linter stuff as per usual. * fix: use StoreCodeUnchecked in snapshot restore func --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
crodriguezvega
added a commit
that referenced
this pull request
Nov 29, 2023
…er. (backport #5146) (#5253) * Use global wasm VM instead of keeping an additional reference in keeper. (#5146) (cherry picked from commit 595e1a9) # Conflicts: # modules/light-clients/08-wasm/keeper/genesis.go # modules/light-clients/08-wasm/keeper/keeper.go # modules/light-clients/08-wasm/keeper/snapshotter.go * fix conflicts --------- Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this isn't strictly necessary, it just keeps all accesses to the VM from a single place.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.