Remove GetSigners from sdk.Msg implementations#5305
Merged
damiannolan merged 15 commits intocosmos:mainfrom Dec 6, 2023
Merged
Remove GetSigners from sdk.Msg implementations#5305damiannolan merged 15 commits intocosmos:mainfrom
sdk.Msg implementations#5305damiannolan merged 15 commits intocosmos:mainfrom
Conversation
ThanhNhann
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
Contributor
|
no worries w.r.t pull request labeler, you can run |
DimitrisJim
reviewed
Dec 4, 2023
modules/apps/27-interchain-accounts/controller/types/msgs_test.go
Outdated
Show resolved
Hide resolved
…/ibc-go into nhan/remove_GetSigners
Contributor
|
note, also grepped for it and found GetSigners for a mock message, see: ./modules/apps/27-interchain-accounts/types/codec_test.go:40 I'd assume that can also probably be safely dropped. |
damiannolan
reviewed
Dec 5, 2023
modules/apps/27-interchain-accounts/controller/types/msgs_test.go
Outdated
Show resolved
Hide resolved
modules/apps/27-interchain-accounts/controller/types/msgs_test.go
Outdated
Show resolved
Hide resolved
damiannolan
reviewed
Dec 6, 2023
Contributor
damiannolan
left a comment
damiannolan
left a comment
There was a problem hiding this comment.
Awesome! I just commented on some more tests which could be refactored to remove the suite receiver and use moduletestutil.MakeTestEncodingConfig
Happy to merge after those are addressed 🚀
Contributor
Author
|
Updated, thank @damiannolan for your suggestions ❤️ |
damiannolan
approved these changes
Dec 6, 2023
damiannolan
approved these changes
Dec 6, 2023
Contributor
damiannolan
left a comment
damiannolan
left a comment
There was a problem hiding this comment.
ACK finishing touches, thank you @ThanhNhann! 🚀
DimitrisJim
approved these changes
Dec 6, 2023
Contributor
DimitrisJim
left a comment
DimitrisJim
left a comment
There was a problem hiding this comment.
lgtm, left one minor nit while going through changes
3 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
partially addresses: #4687
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.