chore(api!): move additional methods to light client module#6230
chore(api!): move additional methods to light client module#6230damiannolan merged 7 commits intocosmos:mainfrom
Conversation
TropicalDog17
requested review from
AdityaSripal,
chatton,
colin-axner and
damiannolan
as code owners
WalkthroughWalkthroughThis set of changes primarily involves the restructuring of functions within the Changes
Assessment against linked issues
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
modules/light-clients/06-solomachine/client_state.go (2)
Line range hint
58-58: Consider updating the client state (cs.Sequenceandcs.ConsensusState.Timestamp) only after the signature verification has passed to avoid state inconsistency in case of verification failure.
Line range hint
91-91: Consider updating the client state (cs.Sequenceandcs.ConsensusState.Timestamp) only after the signature verification has passed to avoid state inconsistency in case of verification failure.
TropicalDog17
requested review from
DimitrisJim,
charleenfei,
crodriguezvega and
srdtrk
as code owners
crodriguezvega
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (3)
docs/docs/05-migrations/13-v8-to-v9.md (2)
Line range hint
10-10: Correct the spelling mistake.- migrating to a new version of ibc-go. There are four sections based on the + migrating to a new version of ibc-go. There are four sections based on the
Line range hint
29-30: Add a space between sentences for better readability.- The `exported.ChannelI` and `exported.CounterpartyChannelI` interfaces have been removed. Please use the concrete types. The `exported.ConnectionI` and `exported.CounterpartyConnectionI` interfaces have been removed. Please use the concrete types. + The `exported.ChannelI` and `exported.CounterpartyChannelI` interfaces have been removed. Please use the concrete types. The `exported.ConnectionI` and `exported.CounterpartyConnectionI` interfaces have been removed. Please use the concrete types.CHANGELOG.md (1)
Line range hint
183-183: Remove trailing spaces to maintain clean and professional documentation.- * (apps/27-interchain-accounts) [\#4944](https://github.com/cosmos/ibc-go/pull/4944) Add missing proto interface registration. + * (apps/27-interchain-accounts) [\#4944](https://github.com/cosmos/ibc-go/pull/4944) Add missing proto interface registration.
crodriguezvega
left a comment
crodriguezvega
left a comment
There was a problem hiding this comment.
Thank you for picking up this one, @TropicalDog17!
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- modules/light-clients/06-solomachine/light_client_module.go (6 hunks)
Files skipped from review as they are similar to previous changes (1)
- modules/light-clients/06-solomachine/light_client_module.go
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
CHANGELOG.md (1)
Line range hint
185-185: Remove trailing spaces for cleaner formatting.-
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional Context Used
Path-based Instructions (1)
CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
| * (core/02-client, light-clients) [\#5806](https://github.com/cosmos/ibc-go/pull/5806) Decouple light client routing from their encoding structure. | ||
| * (core/04-channel) [\#5991](https://github.com/cosmos/ibc-go/pull/5991) The client CLI `QueryLatestConsensusState` has been removed. | ||
| * (light-clients/06-solomachine) [\#6037](https://github.com/cosmos/ibc-go/pull/6037) Remove `Initialize` function from `ClientState` and move logic to `Initialize` function of `LightClientModule`. | ||
| * (light-clients/06-solomachine) [\#6230](https://github.com/cosmos/ibc-go/pull/6230) Remove `GetTimestampAtHeight`, `Status` and `UpdateStateOnMisbehaviour` functions from `ClientState` and move logic to functions of `LightClientModule`. |
There was a problem hiding this comment.
Ensure the URL is properly formatted as a Markdown link.
- * (light-clients/06-solomachine) [\#6230](https://github.com/cosmos/ibc-go/pull/6230) Remove `GetTimestampAtHeight`, `Status` and `UpdateStateOnMisbehaviour` functions from `ClientState` and move logic to functions of `LightClientModule`.
+ * (light-clients/06-solomachine) [[\#6230](https://github.com/cosmos/ibc-go/pull/6230)](https://github.com/cosmos/ibc-go/pull/6230) Remove `GetTimestampAtHeight`, `Status` and `UpdateStateOnMisbehaviour` functions from `ClientState` and move logic to functions of `LightClientModule`.Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * (light-clients/06-solomachine) [\#6230](https://github.com/cosmos/ibc-go/pull/6230) Remove `GetTimestampAtHeight`, `Status` and `UpdateStateOnMisbehaviour` functions from `ClientState` and move logic to functions of `LightClientModule`. | |
| * (light-clients/06-solomachine) [[#6230](https://github.com/cosmos/ibc-go/pull/6230)](https://github.com/cosmos/ibc-go/pull/6230) Remove `GetTimestampAtHeight`, `Status` and `UpdateStateOnMisbehaviour` functions from `ClientState` and move logic to functions of `LightClientModule`. |
There was a problem hiding this comment.
all of the changelogs follow the existing format
There was a problem hiding this comment.
@damiannolan, thank you for your input. We'll keep the changelog format consistent with the existing entries as per your guidance. If there's anything else you need, feel free to let me know!
3 participants
Description
closes: #6087
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.Summary by CodeRabbit