fix: noop on UpdateState for invalid misbehaviour#6276
Conversation
WalkthroughWalkthroughThe changes in the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
damiannolan
requested review from
AdityaSripal,
chatton and
colin-axner
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- modules/light-clients/07-tendermint/update.go (1 hunks)
- modules/light-clients/07-tendermint/update_test.go (1 hunks)
Files skipped from review due to trivial changes (1)
- modules/light-clients/07-tendermint/update.go
Additional Context Used
Path-based Instructions (1)
modules/light-clients/07-tendermint/update_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- modules/light-clients/07-tendermint/update.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- modules/light-clients/07-tendermint/update.go
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
ACK, thanks for the quick fix! Lets backport?
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
|
Added backport labels for v7.5 and v8.3 |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- modules/light-clients/07-tendermint/update.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- modules/light-clients/07-tendermint/update.go
damiannolan
requested review from
DimitrisJim,
charleenfei and
crodriguezvega
as code owners
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional Context Used
Path-based Instructions (1)
CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
crodriguezvega
left a comment
crodriguezvega
left a comment
There was a problem hiding this comment.
Thanks, @damiannolan!
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
CHANGELOG.md (2)
Line range hint
175-175: Bare URL used.Consider using descriptive text for the URL to improve readability and accessibility. For example,
[Link Description](https://github.com/cosmos/ibc-go/pull/6193).
Line range hint
190-190: Trailing spaces found.Please remove any trailing spaces to maintain clean code formatting.
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional Context Used
Path-based Instructions (1)
CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
|
* fix: noop on UpdateState for invalid misbehaviour * godoc: update godoc for UpdateState * Update modules/light-clients/07-tendermint/update.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: add changelog --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 4f31a3c) # Conflicts: # modules/light-clients/07-tendermint/update.go
* fix: noop on UpdateState for invalid misbehaviour * godoc: update godoc for UpdateState * Update modules/light-clients/07-tendermint/update.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: add changelog --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 4f31a3c)
…6296) * fix: noop on UpdateState for invalid misbehaviour (#6276) * fix: noop on UpdateState for invalid misbehaviour * godoc: update godoc for UpdateState * Update modules/light-clients/07-tendermint/update.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: add changelog --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 4f31a3c) # Conflicts: # modules/light-clients/07-tendermint/update.go * chore: fix conflicts --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com>
…6297) * fix: noop on UpdateState for invalid misbehaviour (#6276) * fix: noop on UpdateState for invalid misbehaviour * godoc: update godoc for UpdateState * Update modules/light-clients/07-tendermint/update.go Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * chore: add changelog --------- Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 4f31a3c) * chore: rm unused import --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com>
3 participants
Description
closes: #3636
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.Summary by CodeRabbit
light-clients/07-tendermintmodule.