refactor(v7.4.x): performance improvements for update client in ante#6306
refactor(v7.4.x): performance improvements for update client in ante#6306colin-axner merged 7 commits intorelease/v7.4.xfrom
Conversation
* imp: add checkTxUpdateClient to redunant relayer ante decorator * chore: update godoc and duplicate imports * test: add coverage for checkTxUpdateClient func * chore: rename ante func to updateClientCheckTx
|
Important Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
modules/core/ante/ante.go
Outdated
| // NOTE: the folowing avoids panics in ante handler client updates for ibc-go v7.4.x | ||
| // without state machine breaking changes within light client modules. | ||
| switch clientMsg.(type) { | ||
| case *solomachine.Misbehaviour: | ||
| // ignore solomachine misbehaviour for update state in ante | ||
| case *tendermint.Misbehaviour: | ||
| // ignore tendermint misbehaviour for update state in ante | ||
| default: | ||
| heights := clientState.UpdateState(ctx, rrd.k.Codec(), clientStore, clientMsg) | ||
| ctx.Logger().With("module", "x/"+exported.ModuleName).Debug("ante ibc client update", "consensusHeights", heights) |
There was a problem hiding this comment.
Better to explicitly ignore types that will panic rather than try to target types that will not?
Wasm clients should work against v7.x also, but they contain a single ClientMessage type with opaque bytes. Localhost isn't a concern here, and ignore clientMsg anyways.
There was a problem hiding this comment.
Yea, I think it's likely better to target types we know it is safe to ignore. This feels like an okay stop gap solution for a single release line
damiannolan
changed the title
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
Nice fix! ACK, but would be nice with test cases that would normally trigger the panic
…update-client-checktx
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
LGTM! looks good to merge once the linter errors are fixed.
3 participants
Description
Ignore
Misbehaviourtypes for solomachine and tendermint clients when callingUpdateState.ref: #6232
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.