Skip to content

chore: remove RPCs, Request types, add mock responses until removed from dependency. #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chatton merged 5 commits into from
May 30, 2024
Merged

chore: remove RPCs, Request types, add mock responses until removed from dependency. #6433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d25e018
chore: remove RPCs, Request types, add mock responses until removed f…
DimitrisJim May 29, 2024
c595bbc
lint: make lint-fix
DimitrisJim May 30, 2024
ed9a530
Merge branch 'main' into jim/only-keep-resps
DimitrisJim May 30, 2024
29bda1e
chore: fix proto issues
chatton May 30, 2024
864fc8d
chore: merge main
chatton May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions modules/apps/transfer/keeper/grpc_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,3 @@ func (k Keeper) TotalEscrowForDenom(c context.Context, req *types.QueryTotalEscr
Amount: amount,
}, nil
}

// DenomTrace implements the Query/DenomTrace gRPC method
// Deprecated: Please use Denom instead.
func (Keeper) DenomTrace(c context.Context, req *types.QueryDenomTraceRequest) (*types.QueryDenomTraceResponse, error) {
return nil, status.Error(codes.Unimplemented, "unsupported rpc")
}

// DenomTraces implements the Query/DenomTraces gRPC method
// Deprecated: Please use Denoms instead.
func (Keeper) DenomTraces(c context.Context, req *types.QueryDenomTracesRequest) (*types.QueryDenomTracesResponse, error) {
return nil, status.Error(codes.Unimplemented, "unsupported rpc")
}
8 changes: 8 additions & 0 deletions modules/apps/transfer/types/legacy_denomtrace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package types
Copy link
Copy Markdown
Contributor Author

@DimitrisJim DimitrisJim May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't mind moving these elsewhere if people want. just chose a random file for time being.


// TODO: https://github.com/cosmos/ibc-go/issues/6421#issuecomment-2137516426
// Kept around due to dependency. Empty and useless and ideally dropped before v9.
type (
QueryDenomTracesResponse struct{}
QueryDenomTraceResponse struct{}
)
Loading