feat(transfer): add ShouldBeForwarded convenience method to msg transfer

modules/apps/transfer/types/msgs.go

@@ -107,7 +107,7 @@ func (msg MsgTransfer) ValidateBasic() error {
 	}
 
 	// We cannot have non-empty memo and non-empty forwarding hops at the same time.
-	if len(msg.Forwarding.Hops) > 0 && msg.Memo != "" {
+	if msg.ShouldBeForwarded() && msg.Memo != "" {
 		return errorsmod.Wrapf(ErrInvalidMemo, "memo must be empty if forwarding path hops is not empty: %s, %s", msg.Memo, msg.Forwarding.Hops)
 	}
 
@@ -131,6 +131,11 @@ func (msg MsgTransfer) GetCoins() sdk.Coins {
 	return coins
 }
 
+// ShouldBeForwarded determines if the transfer should be forwarded to the next hop.
+func (msg MsgTransfer) ShouldBeForwarded() bool {
+	return len(msg.Forwarding.Hops) > 0
+}
+
 // isValidIBCCoin returns true if the token provided is valid,
 // and should be used to transfer tokens.
 func isValidIBCCoin(coin sdk.Coin) bool {

modules/apps/transfer/types/packet.go

@@ -145,7 +145,7 @@ func (ftpd FungibleTokenPacketDataV2) ValidateBasic() error {
 	}
 
 	// We cannot have non-empty memo and non-empty forwarding path hops at the same time.
-	if len(ftpd.Forwarding.Hops) > 0 && ftpd.Memo != "" {
+	if ftpd.ShouldBeForwarded() && ftpd.Memo != "" {
 		return errorsmod.Wrapf(ErrInvalidMemo, "memo must be empty if forwarding path hops is not empty: %s, %s", ftpd.Memo, ftpd.Forwarding.Hops)
 	}
 

modules/apps/transfer/types/transfer_authorization.go

@@ -60,7 +60,7 @@ func (a TransferAuthorization) Accept(goCtx context.Context, msg proto.Message)
 
 	memo := msgTransfer.Memo
 	// in the case of forwarded transfers, the actual memo is stored in the forwarding path until the final destination
-	if len(msgTransfer.Forwarding.Hops) > 0 {
+	if msgTransfer.ShouldBeForwarded() {
 		memo = msgTransfer.Forwarding.Memo
 	}