Skip to content

(chore) replace reflect.DeepEqual with slices.Equal #6697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bznein merged 6 commits into from
Jun 25, 2024
Merged

(chore) replace reflect.DeepEqual with slices.Equal #6697

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cb26e7
Replace reflect.DeepEqual with slices.Equal
Jun 25, 2024
8297a36
Nit formatting
Jun 25, 2024
bef0a55
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6696/replace…
Jun 25, 2024
e247614
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6696/replace…
Jun 25, 2024
07f49f5
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6696/replace…
crodriguezvega Jun 25, 2024
8df437b
Merge branch 'feat/ics20-v2-path-forwarding' into bznein/6696/replace…
crodriguezvega Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/apps/transfer/types/transfer_authorization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package types
import (
"context"
"math/big"
"reflect"
"slices"
"strings"

Expand Down Expand Up @@ -189,8 +188,12 @@ func isAllowedForwarding(hops []Hop, allowed []Hops) bool {
return true
}

// We want to ensure that at least one of the Hops in "allowed"
// is equal to "hops".
// Note that we can't use slices.Contains() as that is a generic
// function that requires the type Hop to satisfy the "comparable" constraint.
for _, allowedHops := range allowed {
if reflect.DeepEqual(hops, allowedHops.Hops) {
if slices.Equal(hops, allowedHops.Hops) {
return true
}
}
Expand Down