refactor(core)!: move telemetry into internal folder#6763
refactor(core)!: move telemetry into internal folder#6763crodriguezvega merged 5 commits intomainfrom
Conversation
DimitrisJim
requested review from
AdityaSripal,
chatton,
colin-axner and
damiannolan
as code owners
crodriguezvega
left a comment
crodriguezvega
left a comment
There was a problem hiding this comment.
Also nice cleanup!
| ibcmetrics "github.com/cosmos/ibc-go/v8/modules/core/metrics" | ||
| ) | ||
|
|
||
| func ReportCreateClient(clientType string) { |
There was a problem hiding this comment.
Should we add doc strings to all these public functions?
There was a problem hiding this comment.
That might be nice. In case someone is wondering if they should use them or not, a bit of explanation on how and when they are supposed to be used.
Potentially a small text or readme even on how we use telemetry?
There was a problem hiding this comment.
mentioned in other PR that completely indifferent to docu strings considering they are internal use only. A small description on telemetry usage would be nice though I am still not entirely sure who consumes these atm.
gjermundgaraba
left a comment
gjermundgaraba
left a comment
There was a problem hiding this comment.
This is a great cleanup :) Love stuff like this!
…separate folder for core/02-client.
DimitrisJim
force-pushed
the
jim/internal-telemetry-core
branch
from
10681b9 to
72d4205
Compare
|
4 participants
Description
Additionally, move the
metric.gofiles fromtypes/into ametricspackage to handle import cycles. This can contain all labels for the core module.closes: #6425
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.