Skip to content

create generic helper function for parsing event attributes#6792

Merged
DimitrisJim merged 5 commits intocosmos:mainfrom
chandiniv1:chandini/event-helper
Jul 11, 2024
Merged

create generic helper function for parsing event attributes#6792
DimitrisJim merged 5 commits intocosmos:mainfrom
chandiniv1:chandini/event-helper

Conversation

@chandiniv1
Copy link
Copy Markdown
Contributor

@chandiniv1 chandiniv1 commented Jul 10, 2024

closes: #6651

bznein
bznein approved these changes Jul 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bznein bznein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Leaving the last word to Gjermund :)

gjermundgaraba
gjermundgaraba approved these changes Jul 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! Will wait for one more review before merging :)

damiannolan
damiannolan reviewed Jul 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to also use this in other funcs?

ParsePacketFromEvents and ParseAckFromEvents, maybe?

@DimitrisJim
review:
2108afc 
Align sig with other attr helpers (attrs, key)
Slap docusting
Amend contains to re-use it.
Use in ParseAckFromEvents
@DimitrisJim
Merge branch 'main' into chandini/event-helper
c02fb3d
DimitrisJim
DimitrisJim approved these changes Jul 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! pushed some changes, see commit message for em.

Addressed Damian's point, changed in Ack, for Packets I think the switch is more readable than having a lot of ifs one after the other so left it as is.

@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 11, 2024
Merged via the queue into cosmos:main with commit bd2fe00 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@chatton chatton Awaiting requested review from chatton

+3 more reviewers

@damiannolan damiannolan damiannolan approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@bznein bznein bznein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Look into creating a generic helper function for parsing event attributes

5 participants

@chandiniv1 @gjermundgaraba @damiannolan @DimitrisJim @bznein