Skip to content

imp: remove ClientStoreProvider interface in favour of concrete type#6863

Merged
damiannolan merged 1 commit intomainfrom
damian/rm-client-store-provider-interface
Jul 17, 2024
Merged

imp: remove ClientStoreProvider interface in favour of concrete type#6863
damiannolan merged 1 commit intomainfrom
damian/rm-client-store-provider-interface

Conversation

@damiannolan
Copy link
Copy Markdown
Contributor

@damiannolan damiannolan commented Jul 17, 2024

Description

v9 alpha audit

Removes unnecessary interface ClientStoreProvider in favour of concrete type in 02-client.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review July 17, 2024 15:37
colin-axner
colin-axner approved these changes Jul 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🟥 diffs

@damiannolan damiannolan enabled auto-merge July 17, 2024 15:58
DimitrisJim
DimitrisJim approved these changes Jul 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love seeing the brooms out!

@damiannolan damiannolan added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 8730303 Jul 17, 2024
@damiannolan damiannolan deleted the damian/rm-client-store-provider-interface branch July 17, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@chatton chatton Awaiting requested review from chatton

@srdtrk srdtrk Awaiting requested review from srdtrk

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

2 more reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@colin-axner colin-axner colin-axner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@damiannolan @DimitrisJim @colin-axner