chore(06-solomachine, 07-tendermint): make client state methods moved to lcm private#6891
Merged
DimitrisJim merged 6 commits intomainfrom Jul 22, 2024
Merged
Conversation
DimitrisJim
requested review from
AdityaSripal,
chatton,
colin-axner and
damiannolan
as code owners
DimitrisJim
commented
Jul 18, 2024
| ibctesting.AssertEvents(&suite.Suite, expectedEvents, ctx.EventManager().Events().ToABCIEvents()) | ||
|
|
||
| // Assert that client status is now Active | ||
| clientStore := suite.chainA.App.GetIBCKeeper().ClientKeeper.ClientStore(suite.chainA.GetContext(), subjectPath.EndpointA.ClientID) |
Contributor
Author
There was a problem hiding this comment.
tweaked some tests to go through lcm.
DimitrisJim
requested review from
bznein,
crodriguezvega,
gjermundgaraba and
srdtrk
as code owners
DimitrisJim
commented
Jul 18, 2024
DimitrisJim
changed the title
gjermundgaraba
approved these changes
Jul 19, 2024
Contributor
gjermundgaraba
left a comment
gjermundgaraba
left a comment
There was a problem hiding this comment.
Nice, looks good! 🚀 lgtm!
bznein
approved these changes
Jul 19, 2024
DimitrisJim
commented
Jul 19, 2024
|
colin-axner
approved these changes
Jul 22, 2024
Contributor
|
I guess we could add the api removals in the migration docs |
Contributor
Author
We do mention a bunch for these (interface removal and method removal/made private when necessary). https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/13-v8-to-v9.md#api-removals-1 If I'm missing something, lmk and I'll just add to em in a folow up! |
10 tasks
damiannolan
added a commit
that referenced
this pull request
Jul 23, 2024
… to lcm private (#6891) (#6912) * chore(06-solomachine, 07-tendermint)make client state methods moved to lcm private. * docs: add changelog, add to migration doc. * Update CHANGELOG.md * Update docs/docs/05-migrations/13-v8-to-v9.md (cherry picked from commit a6fd4d7) Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com> Co-authored-by: Damian Nolan <damiannolan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
surfaced during alpha audit of v9.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.