api!: rename path to merkle path for contract api json msgs#6923
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
base branch updated |
crodriguezvega
left a comment
There was a problem hiding this comment.
Thanks, @damiannolan!
modules/light-clients/08-wasm/go.mod
Outdated
| go 1.21 | ||
|
|
||
| retract ( | ||
| // explicitly break api for client contracts |
There was a problem hiding this comment.
Maybe something more explicit? rename field of JSON-encoded verify messages from path to merlke_path, or something like that.
There was a problem hiding this comment.
I updated with a more informative godoc message. Let me know what you think
|
Should we also open a PR targeting to main with these changes? (and backport to v9.0.x, so that when we create the release branch for 08-wasm compatible with v9 we also have the changes there) |
985f266
into
08-wasm/release/v0.4.x+ibc-go-v8.3.x-wasmvm-v2.0.x
Description
Explicitly break the api of json encoded contract msgs
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.