Skip to content

imp!: removed 'ConsensusHost' interface#6937

Merged
srdtrk merged 43 commits intomainfrom
feat/rm-cs-validation
Aug 6, 2024
Merged

imp!: removed 'ConsensusHost' interface#6937
srdtrk merged 43 commits intomainfrom
feat/rm-cs-validation

Conversation

@srdtrk
Copy link
Copy Markdown
Member

@srdtrk srdtrk commented Jul 24, 2024

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@srdtrk srdtrk added 03-connection 02-client protobuf Proto file definitions and protobuf code generation backport-to-v9.0.x labels Jul 24, 2024
colin-axner
colin-axner reviewed Jul 29, 2024
View reviewed changes
@colin-axner colin-axner self-assigned this Jul 29, 2024
colin-axner
colin-axner reviewed Jul 30, 2024
View reviewed changes
colin-axner
colin-axner approved these changes Jul 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo! Super excited with all these red diffs. So nice to see a reduction in complexity!! Thanks for ripping this out @srdtrk and thank you @crodriguezvega for the docs!

I think it might be nice to keep an eye on code cov here. I think I found 1 small unit tests which should be added back, and I'm wondering it might be hard to catch others accidentally removed like this

modules/core/03-connection/keeper/handshake.go
// generate a new connection
connectionID := k.GenerateConnectionIdentifier(ctx)

// check that the consensus height the counterparty chain is using to store a representation
Copy link
Copy Markdown
Contributor

@colin-axner colin-axner Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these diffs are the ones we will backport

modules/core/03-connection/types/msgs.go
Comment on lines -109 to -111
if msg.PreviousConnectionId != "" {
return errorsmod.Wrap(ErrInvalidConnectionIdentifier, "previous connection identifier must be empty, this field has been deprecated as crossing hellos are no longer supported")
}
Copy link
Copy Markdown
Contributor

@colin-axner colin-axner Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #6987 as I feel we should just reserve this field now

@colin-axner colin-axner removed their assignment Jul 30, 2024
@colin-axner colin-axner added this to the v9.0.0 milestone Jul 30, 2024
DimitrisJim
DimitrisJim approved these changes Aug 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely to see this, great trimming! I also noticed we have the Staking keeper interface still in 02-client's expected keeper's, might as well drop that too.

srdtrk and others added 7 commits August 1, 2024 16:12
@srdtrk
imp: removed unused keeper
84b92b0
@srdtrk @colin-axner
Update CHANGELOG.md
4e7a4f6 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@srdtrk @colin-axner
Update docs/docs/05-migrations/13-v8-to-v9.md
01eb933 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@srdtrk @colin-axner
Update docs/docs/05-migrations/13-v8-to-v9.md
4153f6f 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@srdtrk
merge: branch 'main' into feat/rm-cs-validation
ca3c141
@srdtrk
Merge branch 'main' into feat/rm-cs-validation
934f8e8
@colin-axner
Merge branch 'main' into feat/rm-cs-validation
7059e27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Farhad-Shabani Farhad-Shabani mentioned this pull request Aug 5, 2024
Open
@srdtrk srdtrk added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 2028e9a Aug 6, 2024
@srdtrk srdtrk deleted the feat/rm-cs-validation branch August 6, 2024 01:33
mergify bot pushed a commit that referenced this pull request Aug 6, 2024
@srdtrk @mergify
imp!: removed 'ConsensusHost' interface (#6937)
dd18f5f 
* imp(02-client,03-connection)!: remove `ValidateSelfClient` (#6853)

* imp: removed ValidateSelfClient

* docs: updated a godoc

* imp: deleted consensus host from core

* imp(08-wasm): removed consensus host

* imp: fix linter

* imp: fixed linter

* imp: fixed simapp

* imp: updated docs

* imp: removed more code

* revert

* imp: removed unneeded proto fields

* imp: lint

* lint

* imp: auto generated code

* imp: removed conflicts

* imp: removed more code

* fix: tests

* feat: all tests passing

* fix: added the reserved proto fields back with deprecation notice

* style: linted

* imp: regenerated proto

* imp: review item

* revert: conn name change

* docs: added changelog

* add godoc string of QueryConnectionHandshakeProof

* add migration docs for ibc-go

* Update CHANGELOG.md

* update changelog

* imp(proto): added deprecation notice to field

* imp: ran 'make proto-all'

* imp: removed unused keeper

* Update CHANGELOG.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/docs/05-migrations/13-v8-to-v9.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/docs/05-migrations/13-v8-to-v9.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
(cherry picked from commit 2028e9a)

# Conflicts:
#	CHANGELOG.md
#	docs/docs/01-ibc/02-integration.md
#	docs/docs/05-migrations/13-v8-to-v9.md
#	modules/core/02-client/keeper/keeper.go
#	modules/core/keeper/keeper.go
#	modules/light-clients/08-wasm/CHANGELOG.md
@mergify mergify bot mentioned this pull request Aug 6, 2024
Merged
10 tasks
DimitrisJim pushed a commit that referenced this pull request Aug 7, 2024
@mergify @srdtrk @colin-axner
imp!: removed 'ConsensusHost' interface (backport #6937) (#7057)
ff78dea 
* imp!: removed 'ConsensusHost' interface (#6937)

* imp(02-client,03-connection)!: remove `ValidateSelfClient` (#6853)

* imp: removed ValidateSelfClient

* docs: updated a godoc

* imp: deleted consensus host from core

* imp(08-wasm): removed consensus host

* imp: fix linter

* imp: fixed linter

* imp: fixed simapp

* imp: updated docs

* imp: removed more code

* revert

* imp: removed unneeded proto fields

* imp: lint

* lint

* imp: auto generated code

* imp: removed conflicts

* imp: removed more code

* fix: tests

* feat: all tests passing

* fix: added the reserved proto fields back with deprecation notice

* style: linted

* imp: regenerated proto

* imp: review item

* revert: conn name change

* docs: added changelog

* add godoc string of QueryConnectionHandshakeProof

* add migration docs for ibc-go

* Update CHANGELOG.md

* update changelog

* imp(proto): added deprecation notice to field

* imp: ran 'make proto-all'

* imp: removed unused keeper

* Update CHANGELOG.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/docs/05-migrations/13-v8-to-v9.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

* Update docs/docs/05-migrations/13-v8-to-v9.md

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

---------

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
(cherry picked from commit 2028e9a)

# Conflicts:
#	CHANGELOG.md
#	docs/docs/01-ibc/02-integration.md
#	docs/docs/05-migrations/13-v8-to-v9.md
#	modules/core/02-client/keeper/keeper.go
#	modules/core/keeper/keeper.go
#	modules/light-clients/08-wasm/CHANGELOG.md

* fix merge conflicts, changelog, delete docs, keeper fns

---------

Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
This was referenced Aug 12, 2024
Merged
Merged
Merged
@mergify mergify bot mentioned this pull request Aug 13, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@damiannolan damiannolan Awaiting requested review from damiannolan

@chatton chatton Awaiting requested review from chatton

@gjermundgaraba gjermundgaraba Awaiting requested review from gjermundgaraba

@bznein bznein Awaiting requested review from bznein

3 more reviewers

@crodriguezvega crodriguezvega crodriguezvega left review comments

@colin-axner colin-axner colin-axner approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

02-client 03-connection priority PRs that need prompt reviews protobuf Proto file definitions and protobuf code generation

Projects

None yet

Milestone

v9.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@srdtrk @colin-axner @damiannolan @crodriguezvega @DimitrisJim