Adding version to UnmarshalPacketData interface (backport #6988)#6997
Merged
colin-axner merged 1 commit intorelease/v9.0.xfrom Jul 30, 2024
Merged
Adding version to UnmarshalPacketData interface (backport #6988)#6997colin-axner merged 1 commit intorelease/v9.0.xfrom
colin-axner merged 1 commit intorelease/v9.0.xfrom
Conversation
* chore: adding version to UnmarshalPacketData interface * chore: addressing PR feedback (cherry picked from commit 75ec6e9)
mergify
bot
requested review from
AdityaSripal,
DimitrisJim,
bznein,
chatton,
colin-axner,
crodriguezvega,
damiannolan,
gjermundgaraba and
srdtrk
as code owners
|
colin-axner
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #6976
This PR updates the UnmarshalPacketData to return the underlying application version.
Note: in a few tests, we needed to make them stateful since we are fetching the version via the ics20Wrapper
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.This is an automatic backport of pull request #6988 done by [Mergify](https://mergify.com).