Skip to content

Supply app version to contract keeper#7000

Merged
colin-axner merged 19 commits intomainfrom
cian/issue#6977-supply-app-version-to-contract-keeper
Aug 5, 2024
Merged

Supply app version to contract keeper#7000
colin-axner merged 19 commits intomainfrom
cian/issue#6977-supply-app-version-to-contract-keeper

Conversation

@chatton
Copy link
Copy Markdown
Contributor

@chatton chatton commented Jul 30, 2024

Description

closes: #6977

This PR adds the underlying application version to the callback data and propagates it to the contract keeper interface fns.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@chatton chatton marked this pull request as draft July 30, 2024 15:55
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
61.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@colin-axner
Copy link
Copy Markdown
Contributor

No backport necessary, this should be included in the callbacks release branch (when created)

@chatton chatton marked this pull request as draft July 31, 2024 09:56
@colin-axner colin-axner self-assigned this Aug 5, 2024
@colin-axner colin-axner removed their assignment Aug 5, 2024
@colin-axner colin-axner marked this pull request as ready for review August 5, 2024 09:40
@colin-axner
Copy link
Copy Markdown
Contributor

Thanks @chatton for an elegant solution here!

@colin-axner colin-axner added the priority PRs that need prompt reviews label Aug 5, 2024
Copy link
Copy Markdown
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me! Thanks both for smashing this final issue through!

@colin-axner colin-axner added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 4ace83d Aug 5, 2024
@colin-axner colin-axner deleted the cian/issue#6977-supply-app-version-to-contract-keeper branch August 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority PRs that need prompt reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supply app version to contract keeper

3 participants