chore (api!): removal of capabilites module and all references to it.#7279
chore (api!): removal of capabilites module and all references to it.#7279
Conversation
|
Opening review to trigger E2E |
bznein
requested review from
AdityaSripal,
DimitrisJim,
chatton,
colin-axner,
crodriguezvega,
damiannolan,
gjermundgaraba and
srdtrk
as code owners
colin-axner
left a comment
colin-axner
left a comment
There was a problem hiding this comment.
ACK pending green e2e's
What a beautiful day! 🌞 So happy to see this module removed
| github.com/cosmos/gogoproto v1.7.0/go.mod h1:yWChEv5IUEYURQasfyBW5ffkMHR/90hiHgbNgrtp4j0= | ||
| github.com/cosmos/iavl v1.2.0 h1:kVxTmjTh4k0Dh1VNL046v6BXqKziqMDzxo93oh3kOfM= | ||
| github.com/cosmos/iavl v1.2.0/go.mod h1:HidWWLVAtODJqFD6Hbne2Y0q3SdxByJepHUOeoH4LiI= | ||
| github.com/cosmos/ibc-go/modules/capability v1.0.1 h1:ibwhrpJ3SftEEZRxCRkH0fQZ9svjthrX2+oXdZvzgGI= |
There was a problem hiding this comment.
hm, what is bringing this in as an indirect? 🤔
There was a problem hiding this comment.
go mod why -m github.com/cosmos/ibc-go/modules/capability
# github.com/cosmos/ibc-go/modules/capability
github.com/cosmos/ibc-go/e2e/testsuite
github.com/strangelove-ventures/interchaintest/v8/chain/cosmos
github.com/cosmos/ibc-go/modules/capability
Stack overflow brought me here, now I need to understand what it means :D
There was a problem hiding this comment.
https://github.com/strangelove-ventures/interchaintest/blob/main/chain/cosmos/codec.go#L23
It comes from here, and we import that module from two different files in our e2e/testsuite dir:
https://github.com/cosmos/ibc-go/blob/main/e2e/testsuite/testsuite.go#L15
https://github.com/cosmos/ibc-go/blob/main/e2e/testsuite/tx.go#L12
There was a problem hiding this comment.
oh, ofc its interchaintest 😄
There was a problem hiding this comment.
no worries, was just curious!
bznein
changed the title
DimitrisJim
left a comment
DimitrisJim
left a comment
There was a problem hiding this comment.
beautiful chunky red diff to end your day. what a time to be alive!
|
4 participants
Description
ref: #7273
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.