Skip to content

feat: add support for transfer entire balance for vesting accounts (backport #7650)#7676

Merged
gjermundgaraba merged 1 commit intorelease/v9.0.xfrom
mergify/bp/release/v9.0.x/pr-7650
Dec 12, 2024
Merged

feat: add support for transfer entire balance for vesting accounts (backport #7650)#7676
gjermundgaraba merged 1 commit intorelease/v9.0.xfrom
mergify/bp/release/v9.0.x/pr-7650

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Dec 12, 2024

Description

This allows for the "transfer entire balance" feature to work for vesting accounts.

closes: #7658


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

This is an automatic backport of pull request #7650 done by [Mergify](https://mergify.com).

…7650)

* fix spendable bug

* remove GetBalance from expected keeper

---------

Co-authored-by: DimitrisJim <d.f.hilliard@gmail.com>
(cherry picked from commit b0d5778)
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gjermundgaraba for this! I missed the original PR.

Heads up I've created #7681 for v0.52 as vesting module is rugged

@gjermundgaraba gjermundgaraba merged commit d42b23b into release/v9.0.x Dec 12, 2024
@gjermundgaraba gjermundgaraba deleted the mergify/bp/release/v9.0.x/pr-7650 branch December 12, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants