Conversation
|
Hey @ikalyak, thanks for the PR. Not entirely sure the background for this. It would be helpful if you added some context on why you think the circuit module should be removed. |
|
@gjermundgaraba hello, this #7700 |
damiannolan
left a comment
There was a problem hiding this comment.
Awesome thanks @ikalyak! Could you also remove it from the 08-wasm/testing/simapp?
I think we can keep it in the root ./simapp which we build docker images from in case its even needed for some e2e testing.
@gjermundgaraba the idea was to keep the simapp used for unit testing library as lightweight/trim as possible as circuit isn't a strict requirement for sdk apps.
There may also be other modules that could be removed but I haven't gone through it in depth.
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
This reverts commit 39d8547.
This reverts commit 39d8547.
* Revert "chore: bump to sdk v0.52-rc.2 (#7882)" This reverts commit 4e54444. * Revert "chore: clean up module impls (#7865)" This reverts commit d91eb00. * Revert "fix: sanitize gov v1 proposal in e2e tests for compatibility with 0.52 (#7861)" This reverts commit 39b190a. * Revert "chore: bump sdk versions (#7843)" This reverts commit c29c1ab. * Revert "fix: wasm docker file + wasm simapp gas limit (#7830)" This reverts commit 7f0cf54. * Revert "chore: use header service in localhost client (#7757)" This reverts commit 0bea84d. * Revert "refactor: ibc core runtime env (#7601)" This reverts commit f5e1a4c. * Revert "refactor: use branch service in 29-fee (#7732)" This reverts commit d50f7ba. * Revert "chore: address some linter complaints (#7734)" This reverts commit 83fdb7f. * Revert "chore: refactor event service to 29-fee (#7728)" This reverts commit 0b2866d. * Revert "refactor: update 29-fee to use runtime.Environment (#7617)" This reverts commit c8dc02c. * Revert "refactor: use event service in transfer mod (#7725)" This reverts commit 0e72d08. * Revert "refactor: update transfer to use runtime.Environment (#7615)" This reverts commit fd6a78a. * Revert "Remove circuit module (#7715)" This reverts commit 39d8547. * Revert "refactor: use header info for interchain accounts address generation (#7713)" This reverts commit c15bb5c. * Revert "refactor: update icahost to use runtime.Environment (#7600)" This reverts commit 7aae649. * Revert "chore: update import alias to align (#7710)" This reverts commit a14feef. * Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)" This reverts commit 8575743. * fix unwanted reverts * remove invariant * lint * last go1.23 change * remove unecessary testing keeper * update go version in dockerfile * fix docker image
Description
closes: #7700
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.