Skip to content

chore: fix test remove unused expPass in TestSetAndGetParams#8281

Merged
gjermundgaraba merged 3 commits intocosmos:mainfrom
hungdinh82:hung/TestSetAndGetParams
Apr 13, 2025
Merged

chore: fix test remove unused expPass in TestSetAndGetParams#8281
gjermundgaraba merged 3 commits intocosmos:mainfrom
hungdinh82:hung/TestSetAndGetParams

Conversation

@hungdinh82
Copy link
Copy Markdown
Contributor

Description

ref: #7175


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@hungdinh82
Copy link
Copy Markdown
Contributor Author

Because test always passes, no need for expErr

Copy link
Copy Markdown
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gjermundgaraba gjermundgaraba added this pull request to the merge queue Apr 13, 2025
Merged via the queue into cosmos:main with commit 772b0d7 Apr 13, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants