Skip to content

chore: remove datahash from ica account creation#8307

Merged
AdityaSripal merged 2 commits intomainfrom
gjermund/remove-data-hash-from-ica-account-creation
Apr 16, 2025
Merged

chore: remove datahash from ica account creation#8307
AdityaSripal merged 2 commits intomainfrom
gjermund/remove-data-hash-from-ica-account-creation

Conversation

@gjermundgaraba
Copy link
Copy Markdown
Contributor

Description

closes: #8211


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@sonarqubecloud
Copy link
Copy Markdown

@AdityaSripal AdityaSripal added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 39b4dfb Apr 16, 2025
52 checks passed
@AdityaSripal AdityaSripal deleted the gjermund/remove-data-hash-from-ica-account-creation branch April 16, 2025 08:25
mergify bot pushed a commit that referenced this pull request Apr 16, 2025
AdityaSripal pushed a commit that referenced this pull request Apr 16, 2025
(cherry picked from commit 39b4dfb)

Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataHash is used but not set on sdk v0.50 for ica account creation

2 participants