e2e: Create only required number of chains.#8371
Merged
DeshErBojhaa merged 17 commits intomainfrom May 12, 2025
Merged
Conversation
DeshErBojhaa
requested review from
AdityaSripal,
gjermundgaraba and
srdtrk
as code owners
gjermundgaraba
approved these changes
May 12, 2025
Contributor
gjermundgaraba
left a comment
gjermundgaraba
left a comment
There was a problem hiding this comment.
Very nice! This looks like a very solid improvement to me 🙌
Thank you ❤️
Just left a couple of nits you can deal with and then merge this 🚀
Contributor
|
Oh, and let's figure out the failing tests too, though ^^ |
Contributor
|
I really think that you may need some help with CI, but I'm unable to help with those kinds of settings currently. |
DeshErBojhaa
added a commit
that referenced
this pull request
May 12, 2025
* sync deps * feat: create only necessary chains * updated changelog * feat: default chain setings * fix: missing tags for chain C and D * test * chore: remove e2e fork and draft restrictions (#8359) * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * sync deps * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * sync deps * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * fix dep * sync dep * fix missing tags for C and D * remove comments --------- Signed-off-by: tamjidahmed <mail.to.tamjid@gmail.com> Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
DeshErBojhaa
added a commit
that referenced
this pull request
May 12, 2025
* sync deps * feat: create only necessary chains * updated changelog * feat: default chain setings * fix: missing tags for chain C and D * test * chore: remove e2e fork and draft restrictions (#8359) * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * sync deps * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * sync deps * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * fix dep * sync dep * fix missing tags for C and D * remove comments --------- Signed-off-by: tamjidahmed <mail.to.tamjid@gmail.com> Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
DeshErBojhaa
added a commit
that referenced
this pull request
May 12, 2025
* sync deps * feat: create only necessary chains * updated changelog * feat: default chain setings * fix: missing tags for chain C and D * test * chore: remove e2e fork and draft restrictions (#8359) * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * sync deps * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * sync deps * bump wasmvm to v2.2.4, go-etheruem to v1.15.11, spf13/cast to v1.8.0 (#8369) * fix dep * sync dep * fix missing tags for C and D * remove comments --------- Signed-off-by: tamjidahmed <mail.to.tamjid@gmail.com> Co-authored-by: Gjermund Garaba <gjermund@garaba.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most of the suites require only two chains. And only a few requites four chains.
This PR makes sure only the required amount of chains are created for e2e test suites.
closes: #8362
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.