feat: parse IBC v2 packets from ABCI events#8375
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8375 +/- ##
=======================================
Coverage ? 67.17%
=======================================
Files ? 280
Lines ? 19429
Branches ? 0
=======================================
Hits ? 13052
Misses ? 5794
Partials ? 583
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gjermundgaraba
left a comment
There was a problem hiding this comment.
Noice! This looks very good to me!
The only thing we need to figure out before merging is if we need to keeper the original functions around with a deprecation notice.
Oh, and it should have a changelog entry
|
After checking around a bit more, it looks like there are enough people using this to warrant deprecating the function. So just add it back (and call the new one) with a deprecation notice. |
e1e123e to
76b2041
Compare
AdityaSripal
left a comment
There was a problem hiding this comment.
Excellent work! Nice and clean fix
Here e89a575 |
gjermundgaraba
left a comment
There was a problem hiding this comment.
One tiny comment left to fix, and then this should be ready to merge 🚀
gjermundgaraba
left a comment
There was a problem hiding this comment.
Great work! I'll let the tests pass and when that is done we can merge 🙌
* feat: parse packets v2 from events * fix: lint. Shutup Meg! * refactor: rename function * refactor: extract packet form events * refactor: extract packet form events * sync dep * added deprecation notice * changelog * changelog * changelog * fix unit test --------- Co-authored-by: Gjermund Garaba <gjermund@garaba.net> (cherry picked from commit e1f48d6)
Description
This PR extracts IBC v2 packets from ABCI events.
If the event has attribute
AttributeKeyEncodedPacketHexthen we unmarshall packet form that attribute.If attribute
AttributeKeyEncodedPacketHexnot present, we populate and empty packet from the following four attributes.closes: #7856
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.