chore: rm checksums from proto and migrator#8511
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8511 +/- ##
=======================================
Coverage 56.97% 56.97%
=======================================
Files 291 291
Lines 21336 21336
=======================================
Hits 12157 12157
Misses 8629 8629
Partials 550 550
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Locally the |
There was a problem hiding this comment.
This looks great! Great to get rid of this 🙌
One thing I want to add is a changelog entry, and this should be good to go! :) Just add it to the root level changelog file - we don't really use the changelog file in the 08-wasm folder anymore.
Edit: I see in our checklist we say not to include chore in the changelog, but since this is technically a breaking change, we should add it.
Yeah, we're not gonna block this PR on that. |
|
Yep I followed that principle for the |
…for-storing-08-wasm-checksums
Description
closes: #5749
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) if anything is changed.godoccomments if relevant.Files changedin the GitHub PR explorer.