Skip to content

chore: rm checksums from proto and migrator#8511

Merged
gjermundgaraba merged 7 commits intomainfrom
johnnylarner/ibcgo-30-remove-checksums-type-for-storing-08-wasm-checksums
Jun 10, 2025
Merged

chore: rm checksums from proto and migrator#8511
gjermundgaraba merged 7 commits intomainfrom
johnnylarner/ibcgo-30-remove-checksums-type-for-storing-08-wasm-checksums

Conversation

@johnnylarner
Copy link
Copy Markdown
Contributor

@johnnylarner johnnylarner commented Jun 10, 2025

Description

closes: #5749


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@linear
Copy link
Copy Markdown

linear bot commented Jun 10, 2025

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.97%. Comparing base (99a847a) to head (b6a6163).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8511   +/-   ##
=======================================
  Coverage   56.97%   56.97%           
=======================================
  Files         291      291           
  Lines       21336    21336           
=======================================
  Hits        12157    12157           
  Misses       8629     8629           
  Partials      550      550           
Flag Coverage Δ
08-wasm 66.13% <ø> (ø)
e2e 1.18% <ø> (ø)
ibc-go 62.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnnylarner johnnylarner marked this pull request as ready for review June 10, 2025 11:35
@johnnylarner
Copy link
Copy Markdown
Contributor Author

Locally the proto-check-breaking fails because of the rm to the proto file. I guess this acceptable?

Copy link
Copy Markdown
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Great to get rid of this 🙌

One thing I want to add is a changelog entry, and this should be good to go! :) Just add it to the root level changelog file - we don't really use the changelog file in the 08-wasm folder anymore.

Edit: I see in our checklist we say not to include chore in the changelog, but since this is technically a breaking change, we should add it.

@gjermundgaraba
Copy link
Copy Markdown
Contributor

Locally the proto-check-breaking fails because of the rm to the proto file. I guess this acceptable?

Yeah, we're not gonna block this PR on that.

@johnnylarner
Copy link
Copy Markdown
Contributor Author

Yep I followed that principle for the chore but i'll deffo add it

Copy link
Copy Markdown
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@gjermundgaraba gjermundgaraba merged commit fa3908f into main Jun 10, 2025
51 of 52 checks passed
@gjermundgaraba gjermundgaraba deleted the johnnylarner/ibcgo-30-remove-checksums-type-for-storing-08-wasm-checksums branch June 10, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Checksums type for storing 08-wasm checksums.

2 participants