Skip to content

Multi payload packet #8545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdityaSripal merged 12 commits into from
Jun 23, 2025
Merged

Multi payload packet #8545

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a7c4eea
remove restriction in types package
AdityaSripal Jun 18, 2025
27925fc
fix acknowledgement, and start keeper package testing
AdityaSripal Jun 18, 2025
4203039
04-channel tests
AdityaSripal Jun 19, 2025
f3f306e
add transfer tests
AdityaSripal Jun 19, 2025
2a643ea
Merge branch 'main' into aditya/multi-payload
AdityaSripal Jun 20, 2025
a921b42
CHANGELOG
AdityaSripal Jun 20, 2025
c3f52f3
Merge branch 'aditya/multi-payload' of github.com:cosmos/ibc-go into …
AdityaSripal Jun 20, 2025
003a38c
Merge branch 'main' into aditya/multi-payload
gjermundgaraba Jun 22, 2025
37f19cf
lint
gjermundgaraba Jun 22, 2025
53a99d4
Merge branch 'main' into aditya/multi-payload
gjermundgaraba Jun 22, 2025
f83db84
address review
AdityaSripal Jun 23, 2025
933c996
merge
AdityaSripal Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review
  • Loading branch information
@AdityaSripal
AdityaSripal committed Jun 23, 2025
commit f83db84772bbb47821f210748037a74314066196
10 changes: 4 additions & 6 deletions modules/core/04-channel/v2/keeper/packet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ func (suite *KeeperTestSuite) TestSendPacket() {
var (
path *ibctesting.Path
packet types.Packet
payload types.Payload
expSequence uint64
)

Expand All @@ -43,7 +42,7 @@ func (suite *KeeperTestSuite) TestSendPacket() {
{
"success multiple payloads",
func() {
packet.Payloads = append(packet.Payloads, payload)
packet.Payloads = append(packet.Payloads, packet.Payloads...)
},
nil,
},
Expand Down Expand Up @@ -123,7 +122,7 @@ func (suite *KeeperTestSuite) TestSendPacket() {
path = ibctesting.NewPath(suite.chainA, suite.chainB)
path.SetupV2()

payload = mockv2.NewMockPayload(mockv2.ModuleNameA, mockv2.ModuleNameB)
payload := mockv2.NewMockPayload(mockv2.ModuleNameA, mockv2.ModuleNameB)

timeoutTimestamp := uint64(suite.chainB.GetContext().BlockTime().Add(time.Hour).Unix())

Expand Down Expand Up @@ -538,7 +537,6 @@ func (suite *KeeperTestSuite) TestTimeoutPacket() {
var (
path *ibctesting.Path
packet types.Packet
payload types.Payload
freezeClient bool
)

Expand All @@ -561,7 +559,7 @@ func (suite *KeeperTestSuite) TestTimeoutPacket() {
"success multiple payloads",
func() {
// send packet with multiple payloads
packet.Payloads = append(packet.Payloads, payload)
packet.Payloads = append(packet.Payloads, packet.Payloads...)
_, _, err := suite.chainA.App.GetIBCKeeper().ChannelKeeperV2.SendPacketTest(suite.chainA.GetContext(), packet.SourceClient,
packet.TimeoutTimestamp, packet.Payloads)
suite.Require().NoError(err, "send packet failed")
Expand Down Expand Up @@ -658,7 +656,7 @@ func (suite *KeeperTestSuite) TestTimeoutPacket() {
path.SetupV2()

// create default packet with a timed out timestamp
payload = mockv2.NewMockPayload(mockv2.ModuleNameA, mockv2.ModuleNameB)
payload := mockv2.NewMockPayload(mockv2.ModuleNameA, mockv2.ModuleNameB)

// make timeoutTimestamp 1 second more than sending chain time to ensure it passes SendPacket
// and times out successfully after update
Expand Down