Skip to content

imp: add extra validation to ica msgs #8734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srdtrk merged 6 commits into from
Dec 17, 2025
Merged

imp: add extra validation to ica msgs #8734

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37ffee4
imp: add extra validation
srdtrk Dec 16, 2025
022e13a
chore: lint
srdtrk Dec 16, 2025
9c11ccc
imp: error msg
srdtrk Dec 17, 2025
72b6963
test: fix tests
srdtrk Dec 17, 2025
ba5b42d
Merge branch 'main' into serdar/xxx-imp-ica-validation
aljo242 Dec 17, 2025
f4397fd
docs: document the validation change
srdtrk Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
imp: error msg
  • Loading branch information
@srdtrk
srdtrk committed Dec 17, 2025
commit 9c11ccc39323745488cd63963f6b467dbb65bda9
2 changes: 1 addition & 1 deletion modules/apps/27-interchain-accounts/types/codec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func DeserializeCosmosTx(cdc codec.Codec, data []byte, encoding string) ([]sdk.M
if isEqual, err := equalJSON(data, reconstructedData); err != nil {
return nil, errorsmod.Wrapf(ibcerrors.ErrInvalidType, "cannot compare original and reconstructed JSON: %v", err)
} else if !isEqual {
return nil, errorsmod.Wrapf(ibcerrors.ErrInvalidType, "original and reconstructed JSON do not match")
return nil, errorsmod.Wrapf(ibcerrors.ErrInvalidType, "original and reconstructed JSON do not match, all optional fields must be explicitly set")
}
default:
return nil, errorsmod.Wrapf(ErrInvalidCodec, "unsupported encoding format %s", encoding)
Expand Down