Skip to content

imp: added length validation to MsgCreateClient and CounterpartyMerklePrefix.#8774

Merged
srdtrk merged 12 commits intocosmos:mainfrom
yihuang:validate-hash
Mar 3, 2026
Merged

imp: added length validation to MsgCreateClient and CounterpartyMerklePrefix.#8774
srdtrk merged 12 commits intocosmos:mainfrom
yihuang:validate-hash

Conversation

@yihuang
Copy link
Copy Markdown
Contributor

@yihuang yihuang commented Feb 4, 2026

Description

closes: #8775


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Include changelog entry when appropriate (e.g. chores should be omitted from changelog).
  • Wrote unit and integration tests if relevant.
  • Updated documentation (docs/) if anything is changed.
  • Added godoc comments if relevant.
  • Self-reviewed Files changed in the GitHub PR explorer.
  • Provide a conventional commit message to follow the repository standards.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.61%. Comparing base (dfbe362) to head (bb1b60b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...les/light-clients/07-tendermint/consensus_state.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8774      +/-   ##
==========================================
+ Coverage   66.58%   66.61%   +0.02%     
==========================================
  Files         326      326              
  Lines       17114    17128      +14     
==========================================
+ Hits        11396    11410      +14     
  Misses       5023     5023              
  Partials      695      695              
Flag Coverage Δ
08-wasm 64.81% <ø> (ø)
ibc-go 66.67% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srdtrk srdtrk changed the title fix: hash length is not validated in ConsensusState imp: added length validation to MsgCreateClient and CounterpartyMerklePrefix. Mar 3, 2026
@srdtrk srdtrk merged commit 69d2de0 into cosmos:main Mar 3, 2026
53 checks passed
@yihuang yihuang deleted the validate-hash branch March 4, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing size validations in lightclient and connection creation

3 participants