ICS2: Generic Verification Methods#687
Merged
AdityaSripal merged 2 commits intomasterfrom Mar 17, 2022
Merged
Conversation
mpoke
approved these changes
Mar 16, 2022
Contributor
mpoke
left a comment
mpoke
left a comment
There was a problem hiding this comment.
LGTM. Some minor comments bellow. The only issue that I see is that the two functions are also defined in Implementation strategies.
| ``` | ||
|
|
||
| #### Optional Functions | ||
| `verifyMembership` is a generic proof verification method which verifies a proof of the existence a value at a given `CommitmentPath` at the specified height. |
Contributor
There was a problem hiding this comment.
The names of these functions, i.e., verifyMembership and verifyNonMembership, are already used in ICS2 (see the Implementation strategies section). Also, both names are used in ICS23, but I guess that's okay.
Contributor
Author
There was a problem hiding this comment.
Clarified that the example in this section is the ICS-23 methods
Co-authored-by: Marius Poke <marius.poke@posteo.de>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #684