test failed when bumping ibc-go from v5-beta1 to v5-rc0

[yaruwangway]

bump ibc-go to v5-rc1
then

cd x/inter/tx/keeper
go test . -v

get error:

=== RUN   TestKeeperTestSuite
=== RUN   TestKeeperTestSuite/TestRegisterInterchainAccount
    chain.go:203:
        	Error Trace:	/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/chain.go:203
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/chain.go:159
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/chain.go:190
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/coordinator.go:38
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/keeper_test.go:72
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/suite.go:165
        	Error:      	Should be true
        	Test:       	TestKeeperTestSuite/TestRegisterInterchainAccount
=== RUN   TestKeeperTestSuite/TestSubmitTx
    chain.go:203:
        	Error Trace:	/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/chain.go:203
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/chain.go:159
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/chain.go:190
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/coordinator.go:38
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/keeper_test.go:72
        	            				/Users/yaruwang/code/interchain-accounts-demo/x/inter-tx/keeper/suite.go:165
        	Error:      	Should be true
        	Test:       	TestKeeperTestSuite/TestSubmitTx
--- FAIL: TestKeeperTestSuite (0.05s)
    --- FAIL: TestKeeperTestSuite/TestRegisterInterchainAccount (0.02s)
    --- FAIL: TestKeeperTestSuite/TestSubmitTx (0.02s)
FAIL
FAIL	github.com/cosmos/interchain-accounts/x/inter-tx/keeper	0.547s
FAIL

[AdityaSripal]

Hi Yaru, it looks like you may be using a custom simapp with the ibctesting package? I think a change added here is causing the issue: https://github.com/cosmos/ibc-go/pull/1942/files

Will double check with colin, in the meantime

Could you please confirm that you are using your own custom simapp.

Thanks!

[yaruwangway]

yeah, we are using a custom simapp for testing

[colin-axner]

That looks like the issue, I'll open a pr to fix it

[colin-axner]

Please see cosmos/ibc-go#2148. We will backport to an rc2

[yaruwangway]

hi, I see ibc-go v5-rc2 released!
when i either bump ibc to v5-rc either in gaia or ica-demo repo, hen i run test in x/intertx/keeper :
i get

# github.com/cosmos/interchain-accounts/x/inter-tx/keeper_test [github.com/cosmos/interchain-accounts/x/inter-tx/keeper.test]
./keeper_test.go:51:9: cannot use app (variable of type *app.App) as type ibctesting.TestingApp in return statement:
	*app.App does not implement ibctesting.TestingApp (wrong type for GetStakingKeeper method)
		have GetStakingKeeper() "github.com/cosmos/cosmos-sdk/x/staking/keeper".Keeper
		want GetStakingKeeper() "github.com/cosmos/ibc-go/v5/testing/types".StakingKeeper
./keeper_test.go:111:13: impossible type assertion: chain.App.(*icaapp.App)
	*app.App does not implement ibctesting.TestingApp (wrong type for GetStakingKeeper method)
		have GetStakingKeeper() "github.com/cosmos/cosmos-sdk/x/staking/keeper".Keeper
		want GetStakingKeeper() "github.com/cosmos/ibc-go/v5/testing/types".StakingKeeper
FAIL	github.com/cosmos/interchain-accounts/x/inter-tx/keeper [build failed]
FAIL

so the GetStakingKeeper() returns keeper of ibc staking keeper, not sdk staking keeper?