Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 11 11
Lines 562 562
=======================================
Hits 545 545
Misses 17 17 ☔ View full report in Codecov by Sentry. |
| { | ||
| Repository: "ghcr.io/cosmos/ibc-go-wasm-simd", // FOR LOCAL IMAGE USE: Docker Image Name | ||
| Version: "feat-ibc-eureka", // FOR LOCAL IMAGE USE: Docker Image Tag | ||
| Version: "gjermund-fix-wasm-dockerfile", // FOR LOCAL IMAGE USE: Docker Image Tag |
There was a problem hiding this comment.
can be changed back after cosmos/ibc-go#7830 is merged
srdtrk
left a comment
srdtrk
left a comment
There was a problem hiding this comment.
lgtm. Left a couple comments that can be addressed later. Surprised that the rust packages don't need updates.
| // in order to ensure that the underlying account is created, we need to perform an operation on its behalf. | ||
| // in this case we just send 1 token to itself so the account gets created. | ||
| err := chain.SendFunds(ctx, cosmosUser.KeyName(), ibc.WalletAmount{ | ||
| Address: cosmosUser.FormattedAddress(), | ||
| Denom: chain.Config().Denom, | ||
| Amount: sdkmath.NewInt(1), | ||
| }) | ||
|
|
||
| s.Require().NoError(err) | ||
| s.Require().NoError(testutil.WaitForBlocks(ctx, 2, chain)) |
There was a problem hiding this comment.
GetAndFund test users doesn't do this? Also I thought this requirement was gonna be removed in SDK v0.52
| sdk.GetConfig().SetBech32PrefixForAccount(chain.Config().Bech32Prefix, chain.Config().Bech32Prefix+sdk.PrefixPublic) | ||
| sdk.GetConfig().SetBech32PrefixForValidator( | ||
| chain.Config().Bech32Prefix+sdk.PrefixValidator+sdk.PrefixOperator, | ||
| chain.Config().Bech32Prefix+sdk.PrefixValidator+sdk.PrefixOperator+sdk.PrefixPublic, | ||
| ) |
There was a problem hiding this comment.
maybe we should check that this function works with chains using other prefixes (like osmo instead of cosmos)
| }) | ||
|
|
||
| s.Require().NoError(err) | ||
| s.Require().NoError(testutil.WaitForBlocks(ctx, 2, chain)) |
There was a problem hiding this comment.
We should also check if we really need the WaitForBlocks since this function is ran on a loop in setup. (Shouldn't be too bad tho)
This reverts commit f639c91.
2 participants
Description
Needed for #201 and #202
closes: #207
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.