feat(contact): Adds GitLab for sidebar. Only display contacts that are configured.#2368
feat(contact): Adds GitLab for sidebar. Only display contacts that are configured.#2368JasonRaveling wants to merge 5 commits intocotes2020:masterfrom JasonRaveling:master
Conversation
…fig.yml. For GitHub, GitLab, and Twitter, they will be displayed, regardless of a username being set or not. Updates the conditional for capture/assign of `url` so that it is `nil` if no username was provided. Then when the check for `url` is done for building the link, it will be skipped if no username is configured.
|
This started as just a simple add of GitLab. Then I realized certain contacts (e.g. Twitter) were being added even when none was configured. This pull request also includes an adjustment to the conditional so that if a username is not set for GitHub or Twitter (also GitLab), then it will not be displayed in the sidebar. |
JasonRaveling
changed the title
cotes2020
left a comment
cotes2020
left a comment
There was a problem hiding this comment.
Actually, we don't need to add any configuration in _config.yml; we just need to add gitlab like in the example below.
jekyll-theme-chirpy/_data/contact.yml
Lines 34 to 36 in 401e2af
|
Thanks for pointing that out. After looking a little closer, |
|
Maybe you didn't notice the comments. jekyll-theme-chirpy/_config.yml Lines 14 to 15 in d0f8f95 |
cotes2020
force-pushed
the
master
branch
2 times, most recently
from
758e22f to
29bf95e
Compare
|
Closing out since it will not be implemented. Looking in to adding the adjustment to the conditional so that if a username is not set for GitHub or Twitter (also GitLab), then it will not be displayed in the sidebar. |
2 participants
Type of change
Description
Adds GitLab as an option, similar to GitHub. It is an optional config. When set, it will show the GitLab icon in the sidebar with a link to the GitLab page of the configured username.