Adding support for reading credentials from a netrc file on *nix systems#532
Open
JeffMv wants to merge 6 commits intocoursera-dl:masterfrom
JeffMv:master
Open
Adding support for reading credentials from a netrc file on *nix systems#532JeffMv wants to merge 6 commits intocoursera-dl:masterfrom JeffMv:master
JeffMv wants to merge 6 commits intocoursera-dl:masterfrom
JeffMv:master
Conversation
Code for handling netrc has been adapted from the coursera-dl/coursera-dl repo.
Since login with actual credentials is not allowed, maybe we can add a test that takes the netrc file and its credentials and logs in. The netrc file does not have to be
|
Seems like a good feature to have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨Please review the guidelines for contributing to this repository.
Proposed changes
Added support for providing credentials from a
netrcfile on *nix systems.The code and process has been based on the code of the
coursera-dl/coursera-dlrepo (which was working and tested few years back) and adapted to provide that login option foredx-dlusers.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, please explain why you chose
the solution you did and what alternatives you considered, etc.
Reviewers
If you know the person who can review your code please add a @mention.