Added filename sanitization for non-video resources#556
Open
EugeneLoy wants to merge 1 commit intocoursera-dl:masterfrom
Open
Added filename sanitization for non-video resources#556EugeneLoy wants to merge 1 commit intocoursera-dl:masterfrom
EugeneLoy wants to merge 1 commit intocoursera-dl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds sanitization to filenames given to non-video resources.
At the moment filename for non-video resources is derived from resource url, which may contain non-fs-friendly characters.
For example, running:
... schedules download:
... (note
:character that is used in destination filename and is not fs-friendly).This results in silent failure to download affected resources.