Skip to content

Implement mounting user certificates and keys - #125

Merged
Kirill-Garbar merged 13 commits into
mainfrom
feature/auth-v0
Apr 11, 2024
Merged

Implement mounting user certificates and keys#125
Kirill-Garbar merged 13 commits into
mainfrom
feature/auth-v0

Conversation

@Kirill-Garbar

@Kirill-Garbar Kirill-Garbar commented Apr 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR allows to define user-managed peer, client-server certificates.
It implements security specification:

spec:
...
  security:
    tls:
      peerTrustedCASecret: ca-peer-secret
      peerSecret: peer-secret
      serverSecret: server-secret
      clientTrustedCASecret: ca-client-secret
      clientSecret: client-secret
...

Enabled RBAC and root certificate watching is not part of this PR.

@Kirill-Garbar
Kirill-Garbar marked this pull request as ready for review April 6, 2024 23:00
sircthulhu
Kirill Ilin (sircthulhu) reviewed Apr 7, 2024
View reviewed changes
Comment thread api/v1alpha1/etcdcluster_webhook.go Outdated
Comment thread config/crd/bases/etcd.aenix.io_etcdclusters.yaml
kvaps
Andrei Kvapil (kvaps) reviewed Apr 8, 2024
View reviewed changes
Comment thread examples/certificates/ca-certificate-peer.yaml Outdated
@sircthulhu Kirill Ilin (sircthulhu) added the feature New feature or request label Apr 9, 2024
@sircthulhu

Kirill Ilin (sircthulhu) commented Apr 9, 2024

Copy link
Copy Markdown
Collaborator

This PR relates to #76

lllamnyp
Timofei Larkin (lllamnyp) reviewed Apr 9, 2024
View reviewed changes
Comment thread api/v1alpha1/etcdcluster_types.go
Comment thread api/v1alpha1/etcdcluster_types.go Outdated
Comment thread internal/controller/factory/statefulset.go Outdated
sergeyshevch
Sergey Shevchenko (sergeyshevch) approved these changes Apr 9, 2024
View reviewed changes
Comment thread api/v1alpha1/etcdcluster_types.go
lllamnyp
Timofei Larkin (lllamnyp) reviewed Apr 9, 2024
View reviewed changes
Comment thread api/v1alpha1/etcdcluster_types.go Outdated
Comment thread api/v1alpha1/etcdcluster_types.go Outdated
@Kirill-Garbar
Kirill-Garbar marked this pull request as draft April 9, 2024 20:31
@kvaps Andrei Kvapil (kvaps) mentioned this pull request Apr 10, 2024
Closed
1 task
@Kirill-Garbar
Kirill-Garbar marked this pull request as ready for review April 10, 2024 21:33
@Kirill-Garbar
Kirill-Garbar merged commit 765d551 into main Apr 11, 2024
@Kirill-Garbar
Kirill-Garbar deleted the feature/auth-v0 branch April 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) lllamnyp left review comments
@sircthulhu Kirill Ilin (sircthulhu) sircthulhu approved these changes
@kvaps Andrei Kvapil (kvaps) kvaps approved these changes
@hiddenmarten Oleg Kunitsyn (hiddenmarten) Awaiting requested review from hiddenmarten
@AlexGluck Alex Gluck (AlexGluck) Awaiting requested review from AlexGluck
@sergeyshevch Sergey Shevchenko (sergeyshevch) Awaiting requested review from sergeyshevch

Assignees

No one assigned

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Kirill-Garbar @sircthulhu @kvaps @sergeyshevch @lllamnyp