Skip to content

avoid duplicated downloads in CI by caching files / aligned PCRE and Z3 versions in dev and release builds #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 7 commits into from
Jan 4, 2022
Merged

avoid duplicated downloads in CI by caching files / aligned PCRE and Z3 versions in dev and release builds #3612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ff23c43
moved PCRE and Z3 versions into global environment
firewave Dec 8, 2021
c562b6f
moved PCRE and Z3 downloads into separate steps
firewave Dec 8, 2021
e5ab62c
made sure architecture is in Z3 archive name
firewave Dec 8, 2021
c20f5dc
CI-windows.yml: bumped version, updated mirror and re-enabled install…
firewave Dec 8, 2021
a0bd7d7
release-windows.yml: bumped Z3 version to 4.8.10 to match one used in…
firewave Dec 8, 2021
85ccfe2
CI-windows.yml: avoid unnecessary steps in x86 GUI builds which do no…
firewave Dec 8, 2021
e30290a
avoid duplicated downloads of Z3 and PCRE archives in CI by caching them
firewave Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 36 additions & 9 deletions .github/workflows/CI-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,15 @@ jobs:

runs-on: ${{ matrix.os }}

env:
# see https://www.pcre.org/original/changelog.txt
PCRE_VERSION: 8.45
# see https://github.com/Z3Prover/z3/releases:
Z3_VERSION: 4.8.10

steps:
- uses: actions/checkout@v2
if: matrix.arch == 'x64' || matrix.qt_ver == ''

- name: Set up Python 3.10
if: matrix.qt_ver == ''
Expand All @@ -35,11 +42,23 @@ jobs:
if: matrix.qt_ver == ''
uses: microsoft/setup-msbuild@v1.0.2

- name: Cache PCRE
id: cache-pcre
uses: actions/cache@v2
if: matrix.arch == 'x64' || matrix.qt_ver == ''
with:
path: pcre-${{ env.PCRE_VERSION }}.zip
key: pcre-${{ env.PCRE_VERSION }}

- name: Download PCRE
if: (matrix.arch == 'x64' || matrix.qt_ver == '') && steps.cache-pcre.outputs.cache-hit != 'true'
run: |
curl -fsSL https://github.com/pfultz2/pcre/archive/refs/tags/%PCRE_VERSION%.zip -o pcre-%PCRE_VERSION%.zip || exit /b !errorlevel!

- name: Install PCRE
if: false
if: matrix.arch == 'x64' || matrix.qt_ver == ''
run: |
call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" ${{ matrix.arch }} || exit /b !errorlevel!
curl -fsSL https://ftp.pcre.org/pub/pcre/pcre-%PCRE_VERSION%.zip -o pcre-%PCRE_VERSION%.zip || exit /b !errorlevel!
7z x pcre-%PCRE_VERSION%.zip || exit /b !errorlevel!
cd pcre-%PCRE_VERSION% || exit /b !errorlevel!
cmake . -G "NMake Makefiles" -DCMAKE_BUILD_TYPE=Release -DPCRE_BUILD_PCRECPP=Off -DPCRE_BUILD_TESTS=Off -DPCRE_BUILD_PCREGREP=Off || exit /b !errorlevel!
Expand All @@ -51,18 +70,26 @@ jobs:
copy pcre.lib ..\externals\pcre64.lib || exit /b !errorlevel!
)
env:
# see https://www.pcre.org/original/changelog.txt
PCRE_VERSION: 8.44
CL: /MP

- name: Cache Z3 Library
id: cache-z3
uses: actions/cache@v2
if: matrix.arch == 'x64' || matrix.qt_ver == ''
with:
path: z3-${{ env.Z3_VERSION }}-${{ matrix.arch }}-win.zip
key: z3-${{ env.Z3_VERSION }}-${{ matrix.arch }}-win

- name: Download Z3 library
if: (matrix.arch == 'x64' || matrix.qt_ver == '') && steps.cache-z3.outputs.cache-hit != 'true'
run: |
curl -fsSL https://github.com/Z3Prover/z3/releases/download/z3-%Z3_VERSION%/z3-%Z3_VERSION%-${{ matrix.arch }}-win.zip -o z3-%Z3_VERSION%-${{ matrix.arch }}-win.zip || exit /b !errorlevel!

- name: Install Z3 library
if: matrix.arch == 'x64' || matrix.qt_ver == ''
run: |
curl -fsSL https://github.com/Z3Prover/z3/releases/download/z3-%Z3_VERSION%/z3-%Z3_VERSION%-${{ matrix.arch }}-win.zip -o z3-%Z3_VERSION%-win.zip || exit /b !errorlevel!
7z x z3-%Z3_VERSION%-win.zip -oexternals -r -y || exit /b !errorlevel!
7z x z3-%Z3_VERSION%-${{ matrix.arch }}-win.zip -oexternals -r -y || exit /b !errorlevel!
move externals\z3-%Z3_VERSION%-${{ matrix.arch }}-win externals\z3 || exit /b !errorlevel!
env:
# see https://github.com/Z3Prover/z3/releases:
Z3_VERSION: 4.8.10

# no 32-bit Qt available
- name: Install Qt ${{ matrix.qt_ver }}
Expand Down
40 changes: 34 additions & 6 deletions .github/workflows/release-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,34 @@ jobs:

runs-on: windows-2019

env:
# see https://www.pcre.org/original/changelog.txt
PCRE_VERSION: 8.45
# see https://github.com/Z3Prover/z3/releases:
Z3_VERSION: 4.8.10

steps:
- uses: actions/checkout@v2

- name: Setup msbuild.exe
uses: microsoft/setup-msbuild@v1.0.2

- name: Cache PCRE
id: cache-pcre
uses: actions/cache@v2
with:
path: pcre-${{ env.PCRE_VERSION }}.zip
key: pcre-${{ env.PCRE_VERSION }}

- name: Download PCRE
if: steps.cache-pcre.outputs.cache-hit != 'true'
run: |
curl -fsSL https://github.com/pfultz2/pcre/archive/refs/tags/%PCRE_VERSION%.zip -o pcre-%PCRE_VERSION%.zip

- name: Install PCRE
run: |
curl -fsSL https://github.com/pfultz2/pcre/archive/refs/tags/8.45.zip -o pcre-8.45.zip
7z x pcre-8.45.zip
cd pcre-8.45
7z x pcre-%PCRE_VERSION%.zip
cd pcre-%PCRE_VERSION%
cmake . -G "Visual Studio 16 2019" -A x64
msbuild -m PCRE.sln /p:Configuration=Release /p:Platform=x64
dir
Expand All @@ -42,11 +59,22 @@ jobs:
copy pcre.h ..\externals
copy Release\pcre.lib ..\externals\pcre64.lib

- name: Cache Z3 Library
id: cache-z3
uses: actions/cache@v2
with:
path: z3-${{ env.Z3_VERSION }}-x64-win.zip
key: z3-${{ env.Z3_VERSION }}-x64-win

- name: Download Z3 library
if: steps.cache-z3.outputs.cache-hit != 'true'
run: |
curl -fsSL https://github.com/Z3Prover/z3/releases/download/z3-%Z3_VERSION%/z3-%Z3_VERSION%-x64-win.zip -o z3-%Z3_VERSION%-x64-win.zip

- name: Install Z3 library
run: |
curl -fsSL https://github.com/Z3Prover/z3/releases/download/z3-4.8.7/z3-4.8.7-x64-win.zip -o z3-4.8.7-win.zip
7z x z3-4.8.7-win.zip -oexternals -r -y
move externals\z3-4.8.7-x64-win externals\z3
7z x z3-%Z3_VERSION%-x64-win.zip -oexternals -r -y
move externals\z3-%Z3_VERSION%-x64-win externals\z3

- name: Install Qt
uses: jurplel/install-qt-action@v2
Expand Down