added an include-what-you-use GitHub Action#3759
Conversation
firewave
force-pushed
the
ci-iwyu
branch
2 times, most recently
from
6ddb873 to
13ffd49
Compare
firewave
changed the title
firewave
changed the title
firewave
force-pushed
the
ci-iwyu
branch
4 times, most recently
from
b3aa300 to
400ffc7
Compare
|
Tickets for false positives: Ticket to omit output when nothing needs to be changed: And the ticket for the slowdown caused by the Qt mappings: |
| #ifdef __linux__ | ||
| #include <sys/syscall.h> | ||
| #include <sys/types.h> | ||
| #include <syscall.h> |
There was a problem hiding this comment.
This change is incorrect. I've been improving the man-pages so that the correct includes are more clear; see syscall(2):
SYNOPSIS
#include <sys/syscall.h> /* Definition of SYS_* constants */
#include <unistd.h>
long syscall(long number, ...);
Feature Test Macro Requirements for glibc (see feature_test_macros(7)):
syscall():
Since glibc 2.19:
_DEFAULT_SOURCE
Before glibc 2.19:
_BSD_SOURCE || _SVID_SOURCE
https://man7.org/linux/man-pages/man2/syscall.2.html
I opened an issue in iwyu(1) regarding that:
include-what-you-use/include-what-you-use#1036
The BSDs also use <sys/syscall.h>:
https://man.openbsd.org/man2/syscall.2
https://www.freebsd.org/cgi/man.cgi?query=syscall&apropos=0&sektion=0&manpath=FreeBSD+13.0-RELEASE+and+Ports&arch=default&format=html
There was a problem hiding this comment.
@alejandro-colomar
Thanks for pointing that out. I implicitly addressed this in the refactoring that is #4359.
3 participants
I used Kali Linux instead since ubuntu does not use the latest include-what-you-use version.
The
// IWYU pragma: keepannotation will also be used by the upcoming IncludeCleaner feature in clangd - see llvm/llvm-project@b673bc3. clangd is integrated with many IDEs.