addons/namingng.py: Improve output and unit test.#5820
Merged
Conversation
addons/namingng.py reported all issues on column 0, which is now fixed. The unit test is updated, and expanded with tests for checking class name, namespace, public and private member variables.
danmar
approved these changes
Jan 3, 2024
Collaborator
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I think this is acceptable and can be merged if you feel it is ready.
please note my comment that the "column" can't be calculated properly when using directives.
Contributor
Author
|
I think it is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For naming issues reported, column was always set to
0, which is now fixed.Global variable naming errors were reported as "Public member" issues, which is also fixed.
The unit test now covers namespaces, class names, public and private member variables.