Don't set pure for const functions [refs #12696]

[chrchr-github]

No description provided.

[chrchr-github]

FWIW here's a reduced example:

class QModelIndex;

struct ResultsTree {   
    void copy();
    QStandardItemModel mModel;
    QItemSelectionModel mSelectionModel{};
};

void ResultsTree::copy()
{
    QString text;
    for (QModelIndex index : mSelectionModel.selectedRows()) {
        QStandardItem* item = mModel.itemFromIndex(index);
        if (!item->parent()) {
            text += item->text() + '\n';
            continue;
        }
    }
}

Before this change, the valueflow was

Line 14
  ! always {!<=-1,!>=2}
  item always symbolic=(mModel.itemFromIndex(index))
Line 15
  item always symbolic=(mModel.itemFromIndex(index))
  '\n' always 10

Those symbolic values disappear without pure, affecting isAliasOf() and ultimaltely isVariableChanged().

[danmar]

as I understand a const function is always pure. does valueflow assume that the function reads from global memory if it's pure?

[chrchr-github]

I'm not sure how ValueFlow uses these attributes.
We also need to figure out what const is supposed to mean in the library, see #6385