Fix #13364 (CI: Use Cppcheck Premium 24.11.0 in cppcheckpremium.yml)#7054
Merged
Merged
Conversation
| premium_version=${{ inputs.premium_version }} | ||
| if [ -z $premium_version ]; then | ||
| premium_version=24.9.0.1 | ||
| premium_version=24.11.0 |
Contributor
There was a problem hiding this comment.
Have you considered adding a /latest/ link?
Pro:
- code says what it means; use the latest
Con:
- external change can effect CI (i.e. update posted, CI now fails)
Collaborator
Author
There was a problem hiding this comment.
I prefer the explicit version, I don't have the intention to always run latest Cppcheck Premium it's just that there has been important problems with older releases that I wanted to avoid so I have used latest in practice.. An important Pro with an explicit version is that it will be seen easily later (for instance 10 years from now) which exact version we used when checking a particular cppcheck-release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.