enabled and fixed -Wfloat-conversion Clang warnings#7156
Merged
Conversation
firewave
commented
Jan 1, 2025
| ValueFlow::Value v; | ||
| combineValueProperties(args[0], args[1], v); | ||
| v.floatValue = std::scalbln(asFloat(args[0]), asFloat(args[1])); | ||
| v.floatValue = std::scalbln(asFloat(args[0]), asInt(args[1])); |
Collaborator
Author
There was a problem hiding this comment.
I wonder if we need test coverage for this and the other mathematical functions (I have not yet checked if we have).
Collaborator
Author
|
After the int128-related cleanups we are left with few of these and as made evident by the changes it makes sense to have proper types and explicit conversions. |
danmar
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.