Skip to content

Misra 17.3 checks finds implicit function calls #7327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 6 commits into from
May 12, 2025
Merged

Misra 17.3 checks finds implicit function calls #7327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ffaf9b7
Check for all implicit function calls
wienans Feb 23, 2025
0018ea2
Detection of Function Pointer definitions
wienans Feb 23, 2025
e0dc612
Add expected 17.3 fails
wienans Feb 23, 2025
7e4ae2b
Remove trailing whitespace
wienans Feb 23, 2025
71be036
Fix trailing whitespace
wienans Feb 23, 2025
1c5165a
Fix for cfg.standards.c
wienans Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions addons/misra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3486,22 +3486,23 @@ def find_recursive_call(search_for_function, direct_call, calls_map, visited=Non
tok = tok.next

def misra_17_3(self, cfg):
# Check for Clang warnings related to implicit function declarations
for w in cfg.clang_warnings:
if w['message'].endswith('[-Wimplicit-function-declaration]'):
self.reportError(cppcheckdata.Location(w), 17, 3)

# Additional check for implicit function calls in expressions
for token in cfg.tokenlist:
if token.str not in ["while", "if"]:
continue
if token.next.str != "(":
continue
tok = token.next
end_token = token.next.link
while tok != end_token:
if tok.isName and tok.function is None and tok.valueType is None and tok.next.str == "(" and \
tok.next.valueType is None and not isKeyword(tok.str, cfg.standards.c) and not isStdLibId(tok.str, cfg.standards.c):
self.reportError(tok, 17, 3)
break
tok = tok.next
if token.isName and token.function is None and token.valueType is None:
if token.next and token.next.str == "(" and token.next.valueType is None:
if token.next.next.str == "*" and \
token.next.next.next.isName and token.next.next.next.valueType is not None and \
token.next.next.next.valueType.pointer > 0 :
# this is a function pointer definition the tokens look like this int16_t ( * misra_8_2_p_a ) ()
# and the int16_t causes the detection as the '(' follows
continue
if not isKeyword(token.str,cfg.standards.c) and not isStdLibId(token.str,cfg.standards.c):
self.reportError(token, 17, 3)

def misra_config(self, data):
for var in data.variables:
Expand Down
65 changes: 36 additions & 29 deletions addons/test/misra/misra-test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ static _Atomic int misra_1_4_var; // 1.4
static _Noreturn void misra_1_4_func(void) // 1.4
{
if (0 != _Generic(misra_1_4_var)) {} // 1.4 17.3
printf_s("hello"); // 1.4
printf_s("hello"); // 1.4 17.3
Comment thread
danmar marked this conversation as resolved.
}

#define MISRA_2_2 (1*60)
Expand Down Expand Up @@ -154,7 +154,7 @@ static void misra_5_2_function_hides_var_31y(void) {}//5.2
static void foo(void)
{
int i;
switch(misra_5_2_func1()) //16.4 16.6
switch(misra_5_2_func1()) //16.4 16.6 17.3
Comment thread
danmar marked this conversation as resolved.
{
case 1:
{
Expand Down Expand Up @@ -248,7 +248,7 @@ int x;
};
static void misra_5_5_func1(void)
{
switch(misra_5_5_func2()) //16.4 16.6
switch(misra_5_5_func2()) //16.4 16.6 17.3
{
case 1:
{
Expand Down Expand Up @@ -680,21 +680,21 @@ static void misra_10_1_ternary(void)
int16_t i16;

a = ui16 << ui16; // 10.6
a = ui16 << (get_bool(42) ? ui16 : ui16);
a = ui16 << (get_bool(42) ? ui16 : (get_bool(34) ? ui16 : ui16));
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : ui16);
a = ui16 << (get_bool(42) ? i16 : (get_bool(34) ? ui16 : ui16)); // 10.1 10.4
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : i16) : ui16); // 10.1 10.4
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : i16); // 10.1 10.4
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8); // 10.4
a = ui16 << (get_bool(42) ? (get_bool(34) ? i16 : ui8) : ui8); // 10.1 10.4
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8) << ui16; // 10.4
a = (get_bool(42) ? (get_bool(34) ? i16 : ui8) : ui8) << ui16; // 10.1 10.4
a = (get_bool(42) ? (get_bool(34) ? ui16 : i8) : ui8) << ui16; // 10.1 10.4
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : i8) << ui16; // 10.1
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8) << (get_bool(19) ? ui16 : ui8); // 10.4
a = (get_bool(42) ? (get_bool(34) ? i16 : ui8) : ui8) << (get_bool(19) ? ui16 : ui8); // 10.1 10.4
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8) << (get_bool(19) ? i16 : ui8); // 10.1 10.4
a = ui16 << (get_bool(42) ? ui16 : ui16); // 17.3
a = ui16 << (get_bool(42) ? ui16 : (get_bool(34) ? ui16 : ui16)); // 17.3
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : ui16); // 17.3
a = ui16 << (get_bool(42) ? i16 : (get_bool(34) ? ui16 : ui16)); // 10.1 10.4 17.3
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : i16) : ui16); // 10.1 10.4 17.3
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : i16); // 10.1 10.4 17.3
a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8); // 10.4 17.3
a = ui16 << (get_bool(42) ? (get_bool(34) ? i16 : ui8) : ui8); // 10.1 10.4 17.3
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8) << ui16; // 10.4 17.3
a = (get_bool(42) ? (get_bool(34) ? i16 : ui8) : ui8) << ui16; // 10.1 10.4 17.3
a = (get_bool(42) ? (get_bool(34) ? ui16 : i8) : ui8) << ui16; // 10.1 10.4 17.3
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : i8) << ui16; // 10.1 17.3
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8) << (get_bool(19) ? ui16 : ui8); // 10.4 17.3
a = (get_bool(42) ? (get_bool(34) ? i16 : ui8) : ui8) << (get_bool(19) ? ui16 : ui8); // 10.1 10.4 17.3
a = (get_bool(42) ? (get_bool(34) ? ui16 : ui8) : ui8) << (get_bool(19) ? i16 : ui8); // 10.1 10.4 17.3
}

static void misra_10_2(void) {
Expand Down Expand Up @@ -727,7 +727,7 @@ static void misra_10_3(uint32_t u32a, uint32_t u32b) {
res = 0.1f; // 10.3
const char c = '0'; // no-warning
bool b = true; // no-warning
uint32_t u = UINT32_C(10); // no-warning
uint32_t u = UINT32_C(10); // 17.3 no-warning
}

static void misra_10_4(u32 x, s32 y) {
Expand Down Expand Up @@ -799,7 +799,7 @@ static void misra_10_7(uint16_t u16a, uint16_t u16b) {
res = u32a * (u16a + u16b); // 10.7
u32a *= u16a + u16b; // 10.7
u32a = ((uint32_t)4 * (uint32_t)2 * (uint32_t)4 ); // no-warning (#10488)
dostuff(&t, (2*60*1000)); // no-warning
dostuff(&t, (2*60*1000)); // 17.3 no-warning
}

static void misra_10_8(u8 x, s32 a, s32 b) {
Expand Down Expand Up @@ -966,8 +966,8 @@ void misra_12_3(int a, int b, int c) {
int a43, a44 = MISRA_12_3_FN3_2(a34, a35); // 12.3

MISRA_12_3_FN3_2_MSG(fprintf(stderr, "test\n")); // 12.3 21.6

f((1,2),3); // TODO
// TODO
f((1,2),3); // 17.3

// third clause: 2 persistent side effects instead of 1 (14.2)
for (i=0; i<10; i++, j++){} // 12.3 14.2
Expand All @@ -981,8 +981,8 @@ void misra_12_3(int a, int b, int c) {
misra_12_3_fn4(misra_12_3_fn7(&a1, 32), &a1);
misra_12_3_fn6(misra_12_3_fn5(&a1, 32), &a1);
misra_12_3_fn6(misra_12_3_fn7(&a1, 32), &a1);
misra_12_3_fn7(maxlen, fn(va, unsigned long), false);
misra_12_3_fn8(maxlen, (unsigned long)((uintptr_t)fn(va, void*)), false);
misra_12_3_fn7(maxlen, fn(va, unsigned long), false); // 17.3
misra_12_3_fn8(maxlen, (unsigned long)((uintptr_t)fn(va, void*)), false); // 17.3

const struct fun_t
{
Expand Down Expand Up @@ -1268,7 +1268,7 @@ static void misra_14_2_init_value_1(int32_t *var);

static void misra_14_2_fn1(bool b) {
for (;i++<10;) {} // 14.2
for (;i<10;dostuff()) {} // 14.2
for (;i<10;dostuff()) {} // 14.2 17.3
int32_t g = 0;
int g_arr[42];
g += 2; // no-warning
Expand All @@ -1286,7 +1286,7 @@ static void misra_14_2_fn1(bool b) {
int i2;
for (misra_14_2_init_value(&i1); i1 < 10; ++i1) {} // no-warning
for (misra_14_2_init_value_1(&i2); i2 < 10; ++i2) {} // no-warning
for (misra_14_2_init_value_2(&i2); i2 < 10; ++i2) {} // no-warning
for (misra_14_2_init_value_2(&i2); i2 < 10; ++i2) {} // 17.3 no-warning

bool abort = false;
for (i = 0; (i < 10) && !abort; ++i) { // 14.2 as 'i' is not a variable
Expand Down Expand Up @@ -1776,7 +1776,7 @@ static void misra_17_1(void) {
va_arg(); // 17.1
va_start(); // 17.1
va_end(); // 17.1
va_copy(); // 17.1
va_copy(); // 17.1 17.3
}

static void misra_17_2_ok_1(void) { ; }
Expand Down Expand Up @@ -1807,8 +1807,15 @@ static void misra_17_2_5(void) {
}

bool (*dostuff)(); //8.2 8.4
struct s173{
int a;
int b;
}
static void misra_17_3(void) {
if (dostuff()) {}
if (dostuff()) {} // no-warning
bool a = dostuff(); // no-warning
dostuff2(); // 17.3
s173 ( *misra_8_2_p_a ) (void); // no-warning
}

static void misra_config(const char* str) {
Expand Down Expand Up @@ -1954,7 +1961,7 @@ static int misra_21_1(void) {
int _a = 42; // no warning: only directives affected
errno = EINVAL; // no warning
_a ++; // no warning
_exit(1); // no warning
_exit(1); // 17.3 no warning
return _a; // no warning
}
static int _misra_21_1_2(void); // no warning
Expand Down
Loading