[6.x] Plugin settings to inertia#18750
Merged
Merged
Conversation
…ture/plugins-page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the plugin settings page over to inertia. Nothing particularly spectacular in here, just taking the previous functionality and moving it over. This avoids the action menu related to the plugins because that was complex enough to warrant a separate PR.
Perhaps the biggest story of this PR is that you can now pass a shortcut into
craft-action-itemin order to render a shortcut within the suffix slot. You can pass it either as a string (S) or as an object ({key: 'S', alt: true, shift: true }) depending on how complex the shortcut is.note: the shortcut is just a visual indication for the moment, you're responsible for hooking that shortcut up all on your own.
This also refactors
craft-copy-buttonandcraft-copy-attributea bit so the tooltip and succes/failure indicators are now associated with the lower levelcraft-copy-buttonwhich is used within the license copy input area.This also adds a storybook specifically for Vue components used within the CP. The one in
@craftcms/cpis only for the web components over there. I found myself needing to tests variations of components within the PR (like the various license states on the plugin page) so storybook seemed like the best option for making those easy to put my eyes on.