fix openssl check for password-argon2#1140
Merged
Merged
Conversation
crazywhalecc
approved these changes
May 16, 2026
| public function getConfigureArg(bool $shared = false): string | ||
| { | ||
| if ($this->builder->getLib('openssl') !== null) { | ||
| if ($this->builder->getExt('openssl')?->isBuildStatic() || $this->isBuildShared()) { |
Owner
There was a problem hiding this comment.
Theoretically we cannot build password-argon2 as a standalone shared extension.
Collaborator
Author
There was a problem hiding this comment.
Doesn't matter anyway, should just fix in v3 branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
closes #1139
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.